feat: relax bounds for EthPubSub
#13203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
accepted this branch's conflictes becaused based on fdb312f |
lean-apple
pushed a commit
to lean-apple/reth
that referenced
this pull request
Dec 12, 2024
Co-authored-by: Matthias Seitz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #13202
This changes
EthPubSubimpl to directly send items to the stream instead of wrapping them intoEthSubscriptionResult. I believe we're not losing much type safety that way and it allows us to avoid being blocked on upstream change in alloy making enum generic over headerEthPubSubbounds are relaxed to not require a concrete receipt generic, thus allowing to remove those bounds for rpc-builder types as well