Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enforce relations between block parts on NodePrimitives #12846

Merged
merged 1 commit into from
Nov 25, 2024
Merged

feat: enforce relations between block parts on NodePrimitives #12846

merged 1 commit into from
Nov 25, 2024

Conversation

klkvr
Copy link
Member

@klkvr klkvr commented Nov 25, 2024

NodePrimitives is pretty much useless without those bounds which are not very restrictive

mattsse
mattsse approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, we definitely need these, which is reasonable because all of the targets will be static struct types

@klkvr klkvr added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit 9f37d40 Nov 25, 2024
41 checks passed
@klkvr klkvr deleted the klkvr/better-primitives branch November 25, 2024 14:00
@emhane emhane mentioned this pull request Nov 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@emhane emhane Awaiting requested review from emhane

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klkvr @mattsse