Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): handle case when first transaction range is None on reth db stats #11107

Merged
merged 5 commits into from
Sep 22, 2024

Conversation

joshieDo
Copy link
Collaborator

@joshieDo joshieDo commented Sep 22, 2024

If there are no transactions from block 0 to 500k, it would show the whole collapsed range as empty as well

from

image

to

image

@joshieDo joshieDo added C-bug An unexpected or incorrect behavior A-cli Related to the reth CLI labels Sep 22, 2024
@joshieDo joshieDo requested a review from shekhirin September 22, 2024 15:24
@joshieDo joshieDo marked this pull request as draft September 22, 2024 15:37
@joshieDo joshieDo marked this pull request as ready for review September 22, 2024 15:42
@joshieDo joshieDo enabled auto-merge September 22, 2024 16:06
@joshieDo joshieDo added this pull request to the merge queue Sep 22, 2024
Merged via the queue into main with commit 0a6845b Sep 22, 2024
35 checks passed
@joshieDo joshieDo deleted the joshie/fix-dbstats branch September 22, 2024 17:01
0xForerunner pushed a commit to 0xForerunner/reth that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cli Related to the reth CLI C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants