Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute or postpone most deprecation-removals scheduled for 2.26 #21926

Merged
merged 6 commits into from
Feb 7, 2025

Conversation

huonw
Copy link
Contributor

@huonw huonw commented Feb 5, 2025

We're starting the 2.26.x release series so the deprecations that were scheduled for removal can be removed. This PR does handles of them.

I've postponed a few, since they were only relatively recently deprecated and require very minimal code on our side, so we can be a little more generous to any users. (e.g. the [GLOBAL].native_options_validation and [ruff] options are unused, so it's just some option definitions that can hang around to be deleted later.)

There's an extra deprecation ready for removal in the Python FaaS code, which is done in #21928 instead, because it's more fiddly/extensive.

@huonw huonw force-pushed the huonw/2.26-removals branch from 3146827 to 7486e0b Compare February 6, 2025 03:13
@huonw huonw force-pushed the huonw/2.26-removals branch from 7486e0b to 2cf5200 Compare February 6, 2025 04:57
@huonw huonw marked this pull request as ready for review February 6, 2025 05:45
@huonw huonw changed the title Execute or postpone deprecation-removals scheduled for 2.26 Execute or postpone most deprecation-removals scheduled for 2.26 Feb 6, 2025
Copy link
Contributor

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but consider removing native_options_validation entirely?

@huonw huonw merged commit bda875d into main Feb 7, 2025
24 checks passed
@huonw huonw deleted the huonw/2.26-removals branch February 7, 2025 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants