Encourage users to switch to the new Dockerfile parser #21859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huonw
changed the title
huonw
force-pushed
the
huonw/dockerfile-rust-parser-phasing-1
branch
from
41ebd8d to
63a8e6a
Compare
benjyw
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts the process to use only the new Rust-based intrinsic Dockerfile parser, by encouraging people to set the
[dockerfile-parser].use_rust_parseroption explicitly, and, hopefully, set it totrue.The deprecation spec here gives us two releases to work through any issues, before we cutting over to the Rust parser by default in 2.27, and then remove the old parser at some point after that. We can easily adjust if we find more issues.