remove docs requirements from dev requirments #1221
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, pinning Sphinx with pip-compile causes Jinja to be pinned as well, which then overwrites the editable install unless it's done afterwards. And adding
-e
in the requirements file causes Dependabot to fail. It doesn't seem like that's going to be solved by pip (pypa/pip#8307), pip-compile (jazzband/pip-tools#1150), or Dependabot (dependabot/feedback#936) any time soon, so for now I'm just going to remove the docs requirements from the dev requirements.Alternatively could have left them in and required doing
pip install -e .
afterpip install -r requirements/dev.txt
, but I figured just removing it would be less error prone. If users need to build the docs locally, they can dopip install -r requirements/doc.in
to get the direct dependencies without the sub-dependency pins. Read the Docs will still use the pinned file because it can install local Jinja after.fixes #1215