Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove docs requirements from dev requirments #1221

Merged
merged 1 commit into from
May 23, 2020
Merged

Conversation

davidism
Copy link
Member

@davidism davidism commented May 23, 2020

Unfortunately, pinning Sphinx with pip-compile causes Jinja to be pinned as well, which then overwrites the editable install unless it's done afterwards. And adding -e in the requirements file causes Dependabot to fail. It doesn't seem like that's going to be solved by pip (pypa/pip#8307), pip-compile (jazzband/pip-tools#1150), or Dependabot (dependabot/feedback#936) any time soon, so for now I'm just going to remove the docs requirements from the dev requirements.

Alternatively could have left them in and required doing pip install -e . after pip install -r requirements/dev.txt, but I figured just removing it would be less error prone. If users need to build the docs locally, they can do pip install -r requirements/doc.in to get the direct dependencies without the sub-dependency pins. Read the Docs will still use the pinned file because it can install local Jinja after.

fixes #1215

otherwise Sphinx will cause Jinja to be pinned
@davidism davidism merged commit 3e41c01 into master May 23, 2020
@davidism davidism deleted the remove-docs-dev branch May 23, 2020 17:58
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot couldn't fetch all your path-based dependencies
1 participant