Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all references for PHP7 to 8 #543

Closed

Conversation

oceanicpanda
Copy link
Contributor

semver:minor
@TisVictress I tried to run the Ruby tests according to https://github.com/paketo-buildpacks/php-dist/blob/main/dependency/actions/compile/binary-builder/README.md however the instructions seem a little broken and I've never used Ruby and copying the commands I could see into the terminal just gave me exceptions I couldn't figure out. Can you please shed some light here?

Summary

Since PHP7 no longer seems to be supported tests should be updated with minimum support versions and all others references should be removed/updated.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • [ n/a] I have added an integration test, if necessary.
  • [ n/a] I have reviewed the styleguide for guidance on my code quality.
  • [x ] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@sophiewigmore
Copy link
Member

sophiewigmore commented Apr 3, 2023

Hey! I'd recommend using the instructions here to compile the dependency: https://github.com/paketo-buildpacks/php-dist/blob/main/dependency/actions/compile/README.md
The code inside of that binary-builder directory is famously hard to run locally. @TisVictress is actually working on refactoring that code in #502 already!

@sophiewigmore
Copy link
Member

@oceanicpanda can we close out this PR?

@oceanicpanda
Copy link
Contributor Author

yep, sorry have been mega busy of late, will try and get back to it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants