Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(types): oci type repositry_url must be percent encoding #150

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

masahiro331
Copy link

OCI specification

repository_url: A repository URL where the artifact may be found, but not intended as the only location. This value is encouraged to identify a location the content may be fetched

pkg:oci/static@sha256:<digest>?repository_url=gcr.io/distroless/static&tag=latest

qualifiers specification

A value must be a percent-encoded string

Must repository_url be percent-encoded?

@stevespringett
Copy link
Member

@pombredanne The test suite, in this spec repo and used by all implementations, do not have repository_url encoded.

@johnmhoran
Copy link
Member

Hi @masahiro331 and thank you for your PR. I see that although most of the proposed changed PURLs are for qualifiers values, one is for a subpath value. My sense is that the '/' in a qualifier value must be percent-encoded, but the '/' in a subpath value must not be encoded. To enable us to tackle these 2 PURL components individually, could you please replace this PR 150 with two separate PRs?

@johnmhoran johnmhoran mentioned this pull request Jan 21, 2025
1 task
@jkowalleck jkowalleck changed the title docs(types): oci type repositry_url must be parcent encoding docs(types): oci type repositry_url must be percent encoding Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants