-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port ObjectSet Tests #121
Merged
thetechnick
merged 8 commits into
package-operator:main
from
erdii:port-objectset-tests
Mar 12, 2025
Merged
Port ObjectSet Tests #121
thetechnick
merged 8 commits into
package-operator:main
from
erdii:port-objectset-tests
Mar 12, 2025
+412
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to enable code completion / intellisense in integration test code Signed-off-by: Josh Gwosdz <[email protected]>
so i can paste long github commit urls Signed-off-by: Josh Gwosdz <[email protected]>
649dc08
to
4fc70ba
Compare
…ngine Signed-off-by: Josh Gwosdz <[email protected]>
…to concrete discovery client Signed-off-by: Josh Gwosdz <[email protected]>
Signed-off-by: Josh Gwosdz <[email protected]>
Loading status checks…
Signed-off-by: Josh Gwosdz <[email protected]>
4fc70ba
to
829598a
Compare
Signed-off-by: Josh Gwosdz <[email protected]>
Loading status checks…
…this PR tried finding a linter to enforce these, but golangci-lint doesn't include one that is capable of this by default. I found aziule/filebuildtag [1] though. [1] https://github.com/aziule/filebuildtag?tab=readme-ov-file#installation-and-usage Signed-off-by: Josh Gwosdz <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
+ Coverage 40.46% 44.60% +4.13%
==========================================
Files 27 29 +2
Lines 2753 2825 +72
==========================================
+ Hits 1114 1260 +146
+ Misses 1536 1458 -78
- Partials 103 107 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The main goal of this PR is to port the ObjectSet integration tests from package operator.
Change Type
Check List Before Merging
Additional Information