Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port ObjectSet Tests #121

Merged
merged 8 commits into from
Mar 12, 2025
Merged

Conversation

erdii
Copy link
Member

@erdii erdii commented Mar 4, 2025

Summary

  • fix(vscode): manually set integration build tag for gopls integration
  • chore(linter): disable long-line-linter for go comments
  • chore(tests): port ObjectSet integration tests to boxcutter RevisionEngine
  • chore: require correct discovery client interface instead of pointer to concrete discovery client
  • chore: clean up some typos
  • fix(reference): always set object namespace to owner's namespace

The main goal of this PR is to port the ObjectSet integration tests from package operator.

Change Type

Check List Before Merging

  • This PR passes all pre-commit hook validations.
  • This PR is fully tested and regression tests are included.
  • Relevant documentation has been updated.

Additional Information

Sorry, something went wrong.

erdii added 2 commits March 6, 2025 10:04
to enable code completion / intellisense in integration test code

Signed-off-by: Josh Gwosdz <[email protected]>
so i can paste long github commit urls

Signed-off-by: Josh Gwosdz <[email protected]>
@erdii erdii force-pushed the port-objectset-tests branch from 649dc08 to 4fc70ba Compare March 6, 2025 09:46
@erdii erdii force-pushed the port-objectset-tests branch from 4fc70ba to 829598a Compare March 6, 2025 10:10
erdii added 2 commits March 7, 2025 09:35
Signed-off-by: Josh Gwosdz <[email protected]>
…this PR

tried finding a linter to enforce these, but golangci-lint doesn't include one that is capable of this by default.

I found aziule/filebuildtag [1] though.

[1] https://github.com/aziule/filebuildtag?tab=readme-ov-file#installation-and-usage

Signed-off-by: Josh Gwosdz <[email protected]>
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 83.11688% with 13 lines in your changes missing coverage. Please review.

Project coverage is 44.60%. Comparing base (fe4da57) to head (02b134c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
test/test_util.go 81.66% 7 Missing and 4 partials ⚠️
cmd/reference/internal/deploy.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   40.46%   44.60%   +4.13%     
==========================================
  Files          27       29       +2     
  Lines        2753     2825      +72     
==========================================
+ Hits         1114     1260     +146     
+ Misses       1536     1458      -78     
- Partials      103      107       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thetechnick thetechnick added this pull request to the merge queue Mar 12, 2025
Merged via the queue into package-operator:main with commit 7d15252 Mar 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants