Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CORS in frontend service #4948

Merged
merged 1 commit into from
Nov 1, 2022
Merged

fix CORS in frontend service #4948

merged 1 commit into from
Nov 1, 2022

Conversation

butonic
Copy link
Member

@butonic butonic commented Nov 1, 2022

We now pass CORS config to the frontend reva service middleware.

fixes #1340

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 1, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@butonic
Copy link
Member Author

butonic commented Nov 1, 2022

ignoring sonar cloud code complexity for the reva config ...

@butonic butonic merged commit c61b959 into master Nov 1, 2022
@delete-merged-branch delete-merged-branch bot deleted the frontend-cors branch November 1, 2022 12:33
ownclouders pushed a commit that referenced this pull request Nov 1, 2022
Author: Jörn Friedrich Dreyer <[email protected]>
Date:   Tue Nov 1 13:33:22 2022 +0100

    fix CORS in frontend service (#4948)

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@micbar micbar mentioned this pull request Nov 25, 2022
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config for Cors headers seems lost during the config refactoring
2 participants