Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add thumbnail support for tiff and bmp files #4634

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Sep 21, 2022

Support generating thumbnails for tiff and bmp files in the thumbnails service.

@kulmann, I guess the mime-types still need to be added to the preview app in the web repository.

@C0rby C0rby requested a review from micbar September 21, 2022 23:32
@C0rby C0rby requested a review from kulmann as a code owner September 21, 2022 23:32
@C0rby C0rby self-assigned this Sep 21, 2022
@C0rby C0rby requested a review from kulmann September 22, 2022 09:37
@C0rby C0rby force-pushed the thumbnail-support-tiff-bmp branch from 85d8f6a to 3914f64 Compare September 23, 2022 08:43
@C0rby C0rby requested a review from kulmann September 23, 2022 08:43
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 👍

@wkloucek wkloucek merged commit a10047c into master Sep 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the thumbnail-support-tiff-bmp branch September 23, 2022 10:10
ownclouders pushed a commit that referenced this pull request Sep 23, 2022
Merge: 8167d02 3914f64
Author: Willy Kloucek <[email protected]>
Date:   Fri Sep 23 12:10:05 2022 +0200

    Merge pull request #4634 from owncloud/thumbnail-support-tiff-bmp

    add thumbnail support for tiff and bmp files
@micbar micbar mentioned this pull request Nov 25, 2022
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants