Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enusre we close the file in time #9472

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Enusre we close the file in time #9472

merged 1 commit into from
Feb 25, 2022

Conversation

TheOneRing
Copy link
Contributor

Close the body device when we finished.
This fixes:

02-25 14:27:42:887 [ debug sync.propagator.upload.tus ]	[ OCC::PropagateUploadFileTUS::finalize ]:	"" "a1c61d6e3a2dbc99d8c78fc9d20f0edf" "f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c!c246992e-fc43-4ea1-8353-cf1740d90d3a"
02-25 14:27:42:887 [ warning sync.vfs.win ]:	"CfOpenWithOplock error C:/Users/hanna/ownCloud44/Marie Curie/CableTie1.1 - Copy.stl WindowsError: ffffffff80070020: The process cannot access the file because it is being used by another process."

@TheOneRing TheOneRing requested a review from a team February 25, 2022 14:35
fmoc
fmoc approved these changes Feb 25, 2022
View reviewed changes
@ownclouders
Copy link
Contributor

Results for GUI-tests https://drone.owncloud.com/owncloud/client/10892/5/1
GUI Logs: (https://cache.owncloud.com/public/owncloud/client/10892/guiReportUpload/index.html)
Server Logs: (https://cache.owncloud.com/public/owncloud/client/10892/guiReportUpload/serverlog.log)

@ownclouders
Copy link
Contributor

Results for GUI-tests https://drone.owncloud.com/owncloud/client/10893/5/1
GUI Logs: (https://cache.owncloud.com/public/owncloud/client/10893/guiReportUpload/index.html)
Server Logs: (https://cache.owncloud.com/public/owncloud/client/10893/guiReportUpload/serverlog.log)

@TheOneRing
Enusre we close the file in time
c33de8b 
Close the body device when we finished.
This fixes:

```
02-25 14:27:42:887 [ debug sync.propagator.upload.tus ]	[ OCC::PropagateUploadFileTUS::finalize ]:	"" "a1c61d6e3a2dbc99d8c78fc9d20f0edf" "f7fbf8c8-139b-4376-b307-cf0a8c2d0d9c!c246992e-fc43-4ea1-8353-cf1740d90d3a"
02-25 14:27:42:887 [ warning sync.vfs.win ]:	"CfOpenWithOplock error C:/Users/hanna/ownCloud44/Marie Curie/CableTie1.1 - Copy.stl WindowsError: ffffffff80070020: The process cannot access the file because it is being used by another process."
```
@TheOneRing TheOneRing merged commit cdd31f6 into master Feb 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the work/tus_fix branch February 25, 2022 15:15
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for GUI-tests https://drone.owncloud.com/owncloud/client/10895/5/1
GUI Logs: (https://cache.owncloud.com/public/owncloud/client/10895/guiReportUpload/index.html)
Server Logs: (https://cache.owncloud.com/public/owncloud/client/10895/guiReportUpload/serverlog.log)

@ownclouders
Copy link
Contributor

Results for GUI-tests https://drone.owncloud.com/owncloud/client/10896/5/1
GUI Logs: (https://cache.owncloud.com/public/owncloud/client/10896/guiReportUpload/index.html)
Server Logs: (https://cache.owncloud.com/public/owncloud/client/10896/guiReportUpload/serverlog.log)

@TheOneRing TheOneRing mentioned this pull request Oct 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmoc fmoc fmoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Desktop Testing
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheOneRing @ownclouders @fmoc