Improve "update available" message in AppImages #8966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheOneRing
reviewed
Sep 7, 2021
src/gui/updater/ocupdater.cpp
Outdated
| #ifdef Q_OS_LINUX | ||
| // https://docs.appimage.org/packaging-guide/environment-variables.html | ||
| // TODO: update once AppImageUpdate has been implemented | ||
| if (qgetenv("APPIMAGE") != nullptr) { |
fmoc
force-pushed
the
work/better-update-message
branch
from
e6378c1 to
3546909
Compare
TheOneRing
reviewed
Sep 15, 2021
src/gui/updater/ocupdater.cpp
Outdated
| // https://docs.appimage.org/packaging-guide/environment-variables.html | ||
| // TODO: update once AppImageUpdate has been implemented | ||
| if (qEnvironmentVariableIsSet("APPIMAGE")) { | ||
| return tr("New %1 available. Please click <a href='%2'>here</a> to download the new AppImage manually.").arg(updateVersion).arg(_updateInfo.web()); |
There was a problem hiding this comment.
Just saw it now, don't use arg().arg() but arg(1,2,3). Use QString::number() for numbers as the normal overload is 💩
fmoc
force-pushed
the
work/better-update-message
branch
from
3546909 to
ec118f0
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #8923. Not the nicest solution, but I didn't want to add another entry to the enum.