Minimal libcloudproviders support #7210

ckamm · 2019-05-27T11:38:01Z

Add it as an optional dependency for linux builds,
controlled by WITH_LIBCLOUDPROVIDERS, which is enabled automatically
if the dependencies are available.
Add code to export sync folders through the library and to add a
minimal "Settings..." menu action.
Set up cloud provider registration by installing a file into a
path like /usr/share/cloud-providers/.
DBus name and path are derived from APPLICATION_REV_DOMAIN by default
and may be overridden with APPLICATION_CLOUDPROVIDERS_DBUS_NAME and
APPLICATION_CLOUDPROVIDERS_DBUS_PATH if necessary.

ckamm · 2019-05-27T11:38:17Z

@jnweiger maybe take a look at the linux-packaging related parts.

guruz · 2019-05-27T11:38:54Z

Since this is a minimal implementation, what about 2.6.1. ? :)

ckamm · 2019-05-27T11:40:49Z

@guruz I'm up for targeting 2.6.1, the main cost is setting up the build. Since it's a new feature I went with 2.7 by default.

ckamm · 2019-05-27T11:44:40Z

Notes on testing: I noticed my system gtk on ubuntu 18.04 does not use libcloudproviders. That's unfortunate and required a custom build of gtk with --enable-cloudproviders. I then run nautilus with LD_PRELOAD=/usr/lib/x86_64-linux-gnu/libcloudproviders.so.0.2.5 LD_LIBRARY_PATH=mygtk/gtk/.libs nautilus.

The ownCloud sync folders should show up in the location picker on the left
The right-click menu of these entries should have a "Settings..." entry.
Clicking it should open the oC settings window.

guruz · 2019-05-27T11:47:44Z

@ckamm You probably discussed this before but just wondering... loading with dlopen/QPlugin might have advantages for building (...but disavtanges for maintainability)?

src/gui/libcloudproviders/libcloudproviders.cmake

dschmidt · 2019-05-27T11:57:13Z

src/gui/libcloudproviders/libcloudproviders.cmake

+
+if(WITH_LIBCLOUDPROVIDERS AND NOT LIBCLOUDPROVIDERS_POSSIBLE)
+    message(FATAL_ERROR "Trying to enable libcloudproviders but dependencies are missing")
+endif()


Is this a runtime dep? If not, why doesn't libcloudproviders doesn't pull it in already? Is it a distro bug?

No distro bug - it's just that we also need access to gio functions if we want to work with cloudproviders. I'll add a comment saying "to enable the cloudproviders feature we need the cloudproviders and gio-2.0 libraries"

I find it odd to couple this so strongly here, I would do this way more naively:
Search for both, enable feature if both are found. No need for microoptimizations.

Ah, you use this to make it "switchable".

Suggestion: use OPTION() for that.

dschmidt · 2019-05-27T12:00:16Z

src/gui/CMakeLists.txt

@@ -189,6 +189,8 @@ IF( WIN32 )
    ENDIF()
 ENDIF()

+include(libcloudproviders/libcloudproviders.cmake)


This is rather unusual.
Usually you would probably put it in CMakeLists.txt file, add it as a subdirectory and define a static target in there (with include dirs and linked libraries) against which you then can link the application.
The way you did it works as well of course.

ckamm · 2019-05-28T06:36:00Z

Screenshot:

ckamm · 2019-05-28T08:05:43Z

Unfortunate complication: libcloudproviders < 0.3.0 crashes when unexporting an account. I've not found a way to determine library version or work around it in code. only enable if target has >=0.3.0 - I've added a build-time version check, but that will not guarantee runtime dependency.

ogoffart

👍

ogoffart · 2019-06-04T06:50:00Z

src/gui/libcloudproviders/libcloudproviders_p.h

+    LibCloudProviders *_q = nullptr;
+
+public slots:
+    void updateExportedFolderList();


BTW, you could have used Q_PRIVATE_SLOT in LibCloudProviders
then LibCloudProvidersPrivate wouldn't need to be a QObject.

src/gui/libcloudproviders/libcloudproviders.cpp

guruz · 2019-06-04T10:18:36Z

The conversation here mentions crashyness, is this relevant for us?
https://bugs.archlinux.org/task/62502

ckamm · 2019-06-04T10:22:23Z

@guruz I read this as "if you enable libcloudproviders support in gtk, some qt applications using GtkFileChooserDialog may crash" - which is probably a bug with how it's integrated into gtk, I doubt it applies to our use here.

guruz · 2019-06-04T10:29:10Z

@ckamm If you're saying that we won't cause this indirectly by depending on this library then great.
(And only gtk compiled with the library will cause the crash)

- Add it as an optional dependency for linux builds, controlled by WITH_LIBCLOUDPROVIDERS, which is enabled automatically if the dependencies are available. Note that >=0.3.0 is required. - Add code to export sync folders through the library and to add a minimal "Settings..." menu action. - Set up cloud provider registration by installing a file into a path like /usr/share/cloud-providers/. - DBus name and path are derived from APPLICATION_REV_DOMAIN by default and may be overridden with APPLICATION_CLOUDPROVIDERS_DBUS_NAME and APPLICATION_CLOUDPROVIDERS_DBUS_PATH if necessary.

guruz · 2019-06-05T09:23:24Z

FYI @hefee @dragotin

ckamm added this to the 2.7.0 milestone May 27, 2019

ckamm requested review from ogoffart and jnweiger May 27, 2019 11:38

ckamm self-assigned this May 27, 2019

dschmidt requested changes May 27, 2019

View reviewed changes

ckamm force-pushed the libcloudproviders branch from 696b5cd to 72fbeb3 Compare May 28, 2019 08:39

ckamm requested a review from dschmidt May 28, 2019 08:40

dschmidt approved these changes May 28, 2019

View reviewed changes

ogoffart approved these changes Jun 4, 2019

View reviewed changes

ckamm force-pushed the libcloudproviders branch from 72fbeb3 to 524bf64 Compare June 5, 2019 08:53

ckamm force-pushed the libcloudproviders branch from 524bf64 to f377d91 Compare June 5, 2019 09:08

ckamm changed the base branch from master to 2.6 June 5, 2019 09:08

ckamm modified the milestones: 2.7.0, 2.6.0 Jun 5, 2019

ckamm mentioned this pull request Jun 5, 2019

Improve gtk/gnome integration by exporting data with libcloudproviders #7209

Closed

ckamm mentioned this pull request Jun 5, 2019

cannot access tray icon, when there is no tray in e.g. gnome #6607

Closed

ckamm merged commit 2c0a379 into 2.6 Jun 7, 2019

delete-merged-branch bot deleted the libcloudproviders branch June 7, 2019 07:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Minimal libcloudproviders support #7210

Minimal libcloudproviders support #7210

ckamm commented May 27, 2019

ckamm commented May 27, 2019

guruz commented May 27, 2019

ckamm commented May 27, 2019

ckamm commented May 27, 2019 •

edited

Loading

guruz commented May 27, 2019

dschmidt May 27, 2019

ckamm May 28, 2019

dschmidt May 28, 2019

dschmidt May 28, 2019

dschmidt May 27, 2019

ckamm commented May 28, 2019

ckamm commented May 28, 2019 •

edited

Loading

ogoffart left a comment

ogoffart Jun 4, 2019

guruz commented Jun 4, 2019

ckamm commented Jun 4, 2019

guruz commented Jun 4, 2019

guruz commented Jun 5, 2019

Minimal libcloudproviders support #7210

Minimal libcloudproviders support #7210

Conversation

ckamm commented May 27, 2019

ckamm commented May 27, 2019

guruz commented May 27, 2019

ckamm commented May 27, 2019

ckamm commented May 27, 2019 • edited Loading

guruz commented May 27, 2019

dschmidt May 27, 2019

Choose a reason for hiding this comment

ckamm May 28, 2019

Choose a reason for hiding this comment

dschmidt May 28, 2019

Choose a reason for hiding this comment

dschmidt May 28, 2019

Choose a reason for hiding this comment

dschmidt May 27, 2019

Choose a reason for hiding this comment

ckamm commented May 28, 2019

ckamm commented May 28, 2019 • edited Loading

ogoffart left a comment

Choose a reason for hiding this comment

ogoffart Jun 4, 2019

Choose a reason for hiding this comment

guruz commented Jun 4, 2019

ckamm commented Jun 4, 2019

guruz commented Jun 4, 2019

guruz commented Jun 5, 2019

ckamm commented May 27, 2019 •

edited

Loading

ckamm commented May 28, 2019 •

edited

Loading