Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[a11y] Move server URL from status label to Account button #11810

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

erikjv
Copy link
Collaborator

@erikjv erikjv commented Aug 19, 2024

The URL in the status label of the account settings page was not always accessible by keyboard. The label will now only show the connection status, and the "Manage Account" button has a new entry for "Open in Web Browser".

Copy link
Contributor

@TheOneRing TheOneRing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^
Looks great, but I think we can clean it up, please correct me if I'm wrong.

@erikjv erikjv force-pushed the work/move-server-url branch from feaf129 to 4cbde2f Compare August 28, 2024 13:27
@erikjv erikjv requested a review from TheOneRing August 28, 2024 13:27
@erikjv erikjv force-pushed the work/move-server-url branch from 4cbde2f to 5ca4ebc Compare August 28, 2024 13:31
TheOneRing
TheOneRing previously approved these changes Aug 28, 2024
@erikjv erikjv enabled auto-merge (rebase) August 28, 2024 13:36
@erikjv erikjv force-pushed the work/move-server-url branch from 5ca4ebc to 6713cb0 Compare August 28, 2024 13:50
@erikjv erikjv force-pushed the work/move-server-url branch from 6713cb0 to 169e88f Compare August 28, 2024 15:25
The URL in the status label of the account settings page was not
always accessible by keyboard. The label will now only show the
connection status, and the "Manage Account" button has a new entry
for "Open in Web Browser".

Fixes: #11800
Fixes: #11772
@erikjv erikjv force-pushed the work/move-server-url branch from 169e88f to 64d9f12 Compare August 29, 2024 15:56
@TheOneRing TheOneRing disabled auto-merge August 30, 2024 07:36
@TheOneRing TheOneRing merged commit 5e608db into master Aug 30, 2024
4 of 6 checks passed
@TheOneRing TheOneRing deleted the work/move-server-url branch August 30, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants