Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spaces: Prevent same default sync folder for multiple accounts #11364

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Spaces: Prevent same default sync folder for multiple accounts #11364

merged 3 commits into from
Jan 5, 2024

Conversation

erikjv
Copy link
Collaborator

@erikjv erikjv commented Nov 13, 2023 •
edited
Loading

Fixes: #11204

@erikjv erikjv self-assigned this Nov 13, 2023
@erikjv erikjv marked this pull request as draft November 13, 2023 17:40
@erikjv erikjv force-pushed the work/prevent-reuse-default-sync-folder branch 2 times, most recently from 0f75cbf to a7fe690 Compare November 13, 2023 17:56
@erikjv erikjv force-pushed the work/prevent-reuse-default-sync-folder branch 2 times, most recently from 77e92f0 to 1f70acf Compare November 16, 2023 17:06
@erikjv erikjv changed the title Introduce metadata tagging functions for files and directories Spaces: Prevent same default sync folder for multiple accounts Nov 16, 2023
@erikjv erikjv force-pushed the work/prevent-reuse-default-sync-folder branch 2 times, most recently from 6d662ee to d852e69 Compare November 22, 2023 15:50
@erikjv
Copy link
Collaborator Author

erikjv commented Nov 22, 2023 •
edited
Loading

To check if the folder containing the spaces is marked:

  • Windows command prompt: more < foldername:com.owncloud.spaces.app
  • macOS terminal: xattr -l foldername
  • Linux terminal: attr -l foldername and attr -g com.owncloud.spaces.app foldername

@erikjv erikjv marked this pull request as ready for review November 23, 2023 14:18
@erikjv erikjv force-pushed the work/prevent-reuse-default-sync-folder branch from d852e69 to 87fdf0b Compare November 23, 2023 14:18
@erikjv erikjv requested review from a team and TheOneRing November 23, 2023 14:19
@erikjv erikjv force-pushed the work/prevent-reuse-default-sync-folder branch from 87fdf0b to d320657 Compare November 24, 2023 16:16
@erikjv
Copy link
Collaborator Author

erikjv commented Nov 30, 2023

To do: do the check for the spaces tag while checking folder paths, so recursively.

TheOneRing
TheOneRing reviewed Dec 1, 2023
View reviewed changes
@erikjv erikjv force-pushed the work/prevent-reuse-default-sync-folder branch 2 times, most recently from 6636510 to bdce7b3 Compare December 4, 2023 17:08
@erikjv erikjv requested a review from TheOneRing December 4, 2023 17:09
@erikjv erikjv force-pushed the work/prevent-reuse-default-sync-folder branch from bdce7b3 to e5229c4 Compare December 4, 2023 17:35
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@erikjv erikjv force-pushed the work/prevent-reuse-default-sync-folder branch 2 times, most recently from afb212d to 14c2e46 Compare December 7, 2023 14:42
TheOneRing
TheOneRing suggested changes Dec 12, 2023
View reviewed changes
@TheOneRing
Copy link
Contributor

Please also add a changelog entry

@erikjv erikjv force-pushed the work/prevent-reuse-default-sync-folder branch from 14c2e46 to 4a15078 Compare January 2, 2024 17:18
@TheOneRing
Copy link
Contributor

Changelog is still missing

@erikjv erikjv force-pushed the work/prevent-reuse-default-sync-folder branch from 4a15078 to 0ea1396 Compare January 3, 2024 14:57
@erikjv erikjv requested a review from TheOneRing January 3, 2024 14:57
@erikjv erikjv force-pushed the work/prevent-reuse-default-sync-folder branch from 0ea1396 to 683e699 Compare January 3, 2024 15:36
TheOneRing
TheOneRing previously approved these changes Jan 4, 2024
View reviewed changes
@TheOneRing
Copy link
Contributor

Please fix the changelog:

file changelog/unreleased/11204: entry type "Spaces" is invalid, valid types: map[Bugfix:2 Change:3 Enhancement:4 Security:1]

@erikjv erikjv force-pushed the work/prevent-reuse-default-sync-folder branch from 683e699 to d5ee4d4 Compare January 4, 2024 14:26
@TheOneRing TheOneRing merged commit 3436c33 into master Jan 5, 2024
@delete-merged-branch delete-merged-branch bot deleted the work/prevent-reuse-default-sync-folder branch January 5, 2024 10:12
@Salipa-Gurung
Copy link
Contributor

Tested #11204 (comment)

@michaelstingl michaelstingl mentioned this pull request Jan 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheOneRing TheOneRing TheOneRing approved these changes

Assignees

@erikjv erikjv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent: Same default sync folder for multiple accounts
3 participants
@erikjv @TheOneRing @Salipa-Gurung