Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't inherit QApplication #10754

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Don't inherit QApplication #10754

merged 1 commit into from
Apr 26, 2023

Conversation

TheOneRing
Copy link
Contributor

@TheOneRing TheOneRing commented Apr 25, 2023 •
edited
Loading

In a second pr I will introduce KDSingleApplication
Issue: #8432

@ownclouders
Copy link
Contributor

ownclouders commented Apr 25, 2023 •
edited
Loading

Results for GUI-tests-ocis https://drone.owncloud.com/owncloud/client/15114/6/1

@TheOneRing TheOneRing force-pushed the work/application branch 2 times, most recently from 8ad9991 to 65b92f9 Compare April 25, 2023 09:39
@TheOneRing TheOneRing requested a review from fmoc April 25, 2023 13:26
@TheOneRing TheOneRing marked this pull request as ready for review April 25, 2023 13:26
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 29 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TheOneRing TheOneRing added this to the Desktop Client 5.0 milestone Apr 25, 2023
@TheOneRing TheOneRing mentioned this pull request Apr 25, 2023
Merged
fmoc
fmoc suggested changes Apr 25, 2023
View reviewed changes
src/gui/application.h
@@ -124,13 +108,16 @@ protected slots:
QTimer _checkConnectionTimer;

QScopedPointer<FolderMan> _folderManager;


static Application *_instance;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple static variable outside this namespace should work, too. Is there any advantage in using a member?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I can access it in the current inline function.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could, too, even if stored outside.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that would make _instance public?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to declare it in a header...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, doesn't matter, really. Feel free to ignore.

@TheOneRing TheOneRing requested a review from fmoc April 26, 2023 08:45
@TheOneRing TheOneRing merged commit daa9e2e into master Apr 26, 2023
@delete-merged-branch delete-merged-branch bot deleted the work/application branch April 26, 2023 09:19
@saw-jan
Copy link
Member

saw-jan commented Jun 8, 2023

Looks like only code refactoring. Nothing is to be tested manually. Moving to Done
CC @TheOneRing

@saw-jan saw-jan mentioned this pull request Jul 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmoc fmoc fmoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Desktop 5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@TheOneRing @ownclouders @saw-jan @fmoc