Fix update channel reset #10627
Merged
Fix update channel reset #10627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We could be more elegant and use the data role for the combobox. |
We need to keep our own copy of the old index to be able to reliably reset the selection if the dialog is rejected.
fmoc
force-pushed
the
work/fix-language-picker
branch
from
b055bb0 to
773c885
Compare
|
Results for GUI-tests-ocis https://drone.owncloud.com/owncloud/client/14854/7/1 💥 The GUI tests failed. GUI Logs: https://cache.owncloud.com/public/owncloud/client/14854/ocis/guiReportUpload/index.html |
|
Fixed. |
|
Results for GUI-tests-oc10 https://drone.owncloud.com/owncloud/client/14854/6/1 💥 The GUI tests failed. GUI Logs: https://cache.owncloud.com/public/owncloud/client/14854/oc10/guiReportUpload/index.html |
|
Kudos, SonarCloud Quality Gate passed! |
2 tasks
TheOneRing
approved these changes
Apr 6, 2023
|
Tested in #10251 (comment) |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to keep our own copy of the old index to be able to reliably reset the selection if the dialog is rejected.