Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore pre 3.0 behaviour of clearing the cookies befor a token refresh #10338

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Restore pre 3.0 behaviour of clearing the cookies befor a token refresh #10338

merged 2 commits into from
Dec 9, 2022

Conversation

TheOneRing
Copy link
Contributor

No description provided.

@TheOneRing TheOneRing force-pushed the work/bigip branch 2 times, most recently from 23461a7 to 31f0cba Compare December 6, 2022 15:31
@TheOneRing TheOneRing marked this pull request as ready for review December 6, 2022 15:34
@TheOneRing TheOneRing added this to the 3.1 milestone Dec 6, 2022
@ownclouders
Copy link
Contributor

Results for GUI-tests-oc10 https://drone.owncloud.com/owncloud/client/13837/6/1

💥 The GUI tests failed.

GUI Logs: https://cache.owncloud.com/public/owncloud/client/13837/oc10/guiReportUpload/index.html

Server Logs: https://cache.owncloud.com/public/owncloud/client/13837/oc10/guiReportUpload/serverlog.log

Screenshots:

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@TheOneRing TheOneRing requested a review from fmoc December 7, 2022 09:01
@TheOneRing TheOneRing added the p2-high Escalation, on top of current planning, release blocker label Dec 8, 2022
@TheOneRing TheOneRing mentioned this pull request Dec 8, 2022
Closed
fmoc
fmoc approved these changes Dec 9, 2022
View reviewed changes
src/libsync/networkjobs/checkserverjobfactory.cpp
CheckServerJobFactory CheckServerJobFactory::createFromAccount(const AccountPtr &account, bool clearCookies, QObject *parent)
{
// in order to receive all ssl erorrs we need a fresh QNam
auto nam = account->credentials()->createAM();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nitpicking, but in other places in the code, we call instances of our own AccessManager as am, not nam; nam is only used when the type is QNetworkAccessManager (e.g., by upcasting).

Feel free to ignore this, though.

@TheOneRing TheOneRing merged commit 960806e into 3.1 Dec 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the work/bigip branch December 9, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmoc fmoc fmoc approved these changes

Assignees
No one assigned
Labels
p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@TheOneRing @ownclouders @fmoc