Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log parseables #10310

Merged
merged 2 commits into from
Nov 25, 2022
Merged

Log parseables #10310

merged 2 commits into from
Nov 25, 2022

Conversation

dragotin
Copy link
Contributor

Changes the log format to:

22-11-23 18:38:34:438 [ info sync.httplogger ]: "5dca3f29-99a7-488b-a35d-8113302e4ba8: Response: PROPFIND 207 (duration(0h, 0min, 0s, 214ms)=214ms) ht...

Note

  1. The year at the beginning of the line to make the time stamp standard compatible and parseable
  2. The duration in milliseconds appended to the "verbose" duration for humans...

fmoc
fmoc suggested changes Nov 24, 2022
View reviewed changes
@dragotin
Copy link
Contributor Author

Yes, I think logging it once is sufficient, but @TheOneRing wanted to have the human readable version as well when she first checked it...

@dragotin dragotin requested a review from fmoc November 25, 2022 08:45
@TheOneRing TheOneRing changed the base branch from master to 3.0 November 25, 2022 09:46
@TheOneRing TheOneRing merged commit 676df5b into 3.0 Nov 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the logParseables branch November 25, 2022 09:57
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dragotin
Copy link
Contributor Author

Thanks for pulling that to 3.0 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheOneRing TheOneRing TheOneRing left review comments

@fmoc fmoc Awaiting requested review from fmoc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dragotin @TheOneRing @fmoc