-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Open in Web" for native clients #9724
Comments
Any update? cc @michaelstingl @dragotin |
I can start working on it next week. |
Turns out that the current approach that fits well for ownCloud web doesn't fit the Desktop Client. Main problem is that the Desktop client can only use mechanisms like WOPI standards defines that you should open the WOPI office application in an iframe. That requirement could maybe be dropped. But the standard also defines that the WOPI office application must be opened with a form POST and the access token must be transported in the form data. Some WOPI office applications ignore that standard and optionally allow to be opened with a GET request and the access token as query parameter in the URL. Collabora is an example for that class. The current development state of this feature uses the GET approach and therefore only works with Collabora. In order to support more office suites we have following options:
I would go for solution 2) because it does not need changes in oC Web and is the most secure solution. @pmaier1 are you ok with solution 2? |
Well, not really happy having to reauthenticate, of course. I agree that 3 would probably also get criticized. If you don't see other solutions, let's go for 2 for now. |
Relevant discussion https://chat.owncloud.com/channel/ocis-internal?msg=gEsa7WyZRTFL8Q3YX |
I don't think that it is possible in a clean way to share the OIDC session from the Desktop client to the browser. It would basically mean that we need to transfer the offline token, which could lead to a ended session in the client (depending on the IDP settings, eg Keycloak's If we're thinking about SSO that is not only used by ownCloud, but also by other applications (in the Web browser) there is quite a chance that the user is already authenticated. It also depends on the session timeouts set on the IDP how often a user needs to re-authenticate itself. |
Alright, thanks for the background. I think solution 2 will work now, as said above. |
Info from @kulmann is that this URL is currently not yet stable. We will need to discuss that tomorrow. |
This is what I'd expect with the given possibilities. Handing-over authentication from native apps to the web needs a bigger concept. Happy to discuss with the backend experts at a later stage… |
When cs3org/reva#3143 and owncloud/ocis#4376 are merged, following functionality is available: https://github.com/owncloud/ocis/blob/7ef7a60d710f2ac582a64417c03b0f0f4336261d/docs/services/app-registry/apps.md#open-a-file-with-the-owncloud-web |
The /app/open-with-web endpoint is now available on oCIS master / latest deployments (see also https://owncloud.dev/services/app-registry/apps/#app-provider-capability) |
Story
As a client user I want to open a file in the Web Office directly from the context menu in my file browser so that I can easily start collaborating with others
Specifics
@TheOneRing
The text was updated successfully, but these errors were encountered: