Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA] Link in modified "About" window does not work #8920

Closed
jnweiger opened this issue Aug 19, 2021 · 2 comments
Closed

[QA] Link in modified "About" window does not work #8920

jnweiger opened this issue Aug 19, 2021 · 2 comments
Milestone
2.9.1

Comments

@jnweiger
Copy link
Contributor

Seen in testpilotcloud-2.9.0-beta1.4914.AppImage on Linux Mint 20.1

  • Open Settings, -> click About
  • A window with version number and some text opens.
  • In case the theme has the modified about option, there is a badly formatted URL
    image

The testpilot theme has

image

image

The theme.json file corresponding to these settings has:
image
@jnweiger jnweiger mentioned this issue Aug 19, 2021
Closed
39 tasks
@github-actions
Copy link

This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Sep 19, 2021
@TheOneRing TheOneRing removed the Stale label Sep 20, 2021
@TheOneRing TheOneRing added this to the 2.9.1 milestone Sep 20, 2021
TheOneRing added a commit that referenced this issue Sep 23, 2021
@TheOneRing
No longer try to concatenate defines
121f498 
Fixes: #8920
@TheOneRing TheOneRing mentioned this issue Sep 23, 2021
Merged
TheOneRing added a commit that referenced this issue Sep 23, 2021
@TheOneRing
No longer try to concatenate defines
97763ad 
Fixes: #8920
TheOneRing added a commit that referenced this issue Sep 23, 2021
@TheOneRing
No longer try to concatenate defines
762ac28 
Fixes: #8920
TheOneRing added a commit that referenced this issue Sep 23, 2021
@TheOneRing
No longer try to concatenate defines
288d2d0 
Fixes: #8920
TheOneRing added a commit that referenced this issue Sep 23, 2021
@TheOneRing
No longer try to concatenate defines
e4671fe 
Fixes: #8920
erikjv pushed a commit that referenced this issue Sep 29, 2021
@TheOneRing @erikjv
No longer try to concatenate defines
d994c96 
Fixes: #8920
@gabi18 gabi18 mentioned this issue Sep 29, 2021
Closed
46 tasks
@gabi18
Copy link
Contributor

gabi18 commented Oct 4, 2021

Confirmed fixed on Windows 10 with client 2.9.1rc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.1
Development

No branches or pull requests
3 participants
@TheOneRing @jnweiger @gabi18