"Remove all dialog": Keep files will make the dialog pop up again and again

[TheOneRing]

After clicking on keep files, a new dialog pops up which asks to keep all files or remove all.

Might have been a special scenario, local db was deleted and all files on the remote where deleted.

[github-actions]

This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

[gabi18]

Couldn't reproduce the issue that the 'Remove all' dialog popups again and again.

• deleted all folder and files on server, clicked on 'Keep files' -> the popup didn't reappear
• deleted all folder and files locally, same as above

[gabi18]

Probably related to #8442 :

When testing to delete all both on server and locally the popup also appears once.
Clicking on 'Keep files' cannot restore the files but they are still visible in the client.

20210216_1612_owncloud.log.0.gz

20210216_1611_owncloud.log.1.gz

[github-actions]

This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

[gabi18]

I could reproduce the issue on Windows 10 with VFS enabled.

Steps done:

1. Enable VFS support in client
2. Delete all folder/files on server
3. The 'Keep files / Remove files' popup appears
4. Click 'Keep files'
   Result: virtual folder/files are kept locally - no attempt to resync (see [QA] No re-sync from client to server after 'Keep files'  #8442)
5. Quit owncloud-client and restart
6. 'Keep files / Remove files' popup appears
   Result: client tries to resync after clicking 'Keep files' but cannot succeed (because of VFS) and the popup appears again and again

[github-actions]

This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

[gabi18]

I could reproduce the issue on Windows 10 with VFS enabled.

Steps done:

1. Enable VFS support in client

2. Delete all folder/files on server

3. The 'Keep files / Remove files' popup appears

4. Click 'Keep files'
   Result: virtual folder/files are kept locally - no attempt to resync (see [[QA] No re-sync from client to server after 'Keep files'  #8442](https://github.com/owncloud/client/issues/8442))

NOT relevant here (for Windows VFS On), the issue above was reported for Linux (VFS Off)

5. Quit owncloud-client and restart

No need to restart on Windows, the popup appears again and again after clicking 'Keep files'. If the files which should be kept are virtual there is no chance to keep them.

6. 'Keep files / Remove files' popup appears
   Result: client tries to resync after clicking 'Keep files' but cannot succeed (because of VFS) and the popup appears again and again

[gabi18]

Seen with ownCloud-3.0.0-daily20220622.7851.x64.msi on Windows 10 21H2:

• the popup appears again and again when clicking "Keep files"

• "Remove all files" stops the endless loop but only removes the dehydrated files and keeps the hydrated

keep-files.log.gz

[fmoc]

TODO:

• abort current sync and pause sync root before displaying dialog
• if keep files: keep current behavior (removing all hacks from the code), start new sync to upload the files again
• if remove all files: remove all files and start a new sync cycle

[nabim777]

Seen with ownCloud-5.0.0.11398--daily20230707 b0734d (download link) on Windows 10 Enterprise Evaluation :

• the popup appears again and again when clicking "Keep files"

• "Remove all files" stops the endless loop but only removes the dehydrated files and keeps the hydrated
  
  ownCloud-0709_23.16.33.080.log

[Salipa-Gurung]

Tested on: Windows10
ownCloud version: ownCloud 5.0.0.11398-daily20230707

Deleting all the files only on the server

• In case of hydrated and Always keep on this device files, both Keep files and Remove all files option works and Remove All Files dialog appears only once. ✔️

• In case of dehydrated files:

  • Keep files option does not work (VFS on) ❌

  • Remove All Files dialog appears again and again. ❌

  • Remove all files button removes all the files. ✔️

    ownCloud.log

Deleting all the folders (empty folders) on the server

• In case of dehydrated, hydrated and Always keep on this device folders both Keep files and Remove all files option works accordingly ✔️
• Remove All Files dialog appears only once ✔️

[TheOneRing]

It makes sense @michaelstingl

[Salipa-Gurung]

Client version

ownCloud 5.0.0.11438-daily20230712 0f63d2
Libraries Qt 6.4.3, OpenSSL 3.1.1 30 May 2023
Using virtual files plugin: wincfapi
windows-10.0.19045

Deleting all the files only on the server

• In case of hydrated and Always keep on this device files, both Keep files and Remove all files option works and Remove All Files dialog appears only once. ✔️

• In case of dehydrated file,

  • Remove All Files dialog does not appear again and again.

  • Remove all files button removes the files ✔️

  • Keep files button does not keep the file ❌ [ instead it removes the dehydrated file ]

    ownCloud.log

Dehydrated files inside folder also gets deleted when keep files button clicked. ❌

Deleting all the folders (empty folders) on the server

• In case of dehydrated, hydrated and Always keep on this device folders both Keep files and Remove all files option works accordingly ✔️
• Remove All Files dialog appears only once ✔️

[TheOneRing]

@Salipa-Gurung @michaelstingl this is expected behavior.
At least if I understand the scenario correctly.
You have dehydrated placeholders locally and all files are removed on the server, this means the virtual files do no longer exist.
We have to remove the local placeholders as they are already gone.

[Salipa-Gurung]

so, can it be closed then?

[michaelstingl]

so, can it be closed then?

yes, close