Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA] Repetitive requestors #8263

Closed
jnweiger opened this issue Nov 29, 2020 · 3 comments
Closed

[QA] Repetitive requestors #8263

jnweiger opened this issue Nov 29, 2020 · 3 comments
Labels
Enhancement

Comments

@jnweiger
Copy link
Contributor

jnweiger commented Nov 29, 2020 •
edited
Loading

Client 2.7.1 on Ubuntu 20.04 connected to demo.owncloud.com

  • Keep it connected over night.
  • Demo.owncloud.com resets itself every hour. Requestors accumulate. A total of 14 requestors, nicely arranged in three stacks.
    image
    image

Expected behaviour: One requestor is sufficient. Sync continues after answering one requestor.
TheOneRing added a commit that referenced this issue Nov 30, 2020
@TheOneRing
Pause sync when remove all dialog is displayed
82aa209 
Fixes: #8263
@TheOneRing TheOneRing mentioned this issue Nov 30, 2020
Merged
TheOneRing added a commit that referenced this issue Nov 30, 2020
@TheOneRing
Pause sync when remove all dialog is displayed
efd5118 
Fixes: #8263
@jnweiger
Copy link
Contributor Author

jnweiger commented Dec 1, 2020 •
edited
Loading

Retested with the appimage found in https://github.com/owncloud/client/pull/8265/checks?check_run_id=1473544279

  • As soon as the first requester comes up, the connection shows the yellow pause icon. OK
  • Clicking the 'Keep files' triggers a sync run. The connection remains paused. BAD

Waiting for further requesters....

TheOneRing added a commit that referenced this issue Dec 1, 2020
@TheOneRing
Pause sync when remove all dialog is displayed
b42f2de 
Fixes: #8263
TheOneRing added a commit that referenced this issue Dec 1, 2020
@TheOneRing
Pause sync when remove all dialog is displayed
8f35362 
Fixes: #8263
@TheOneRing
Copy link
Contributor

Thx for testing, I fixed the remaining issue

@jnweiger
Copy link
Contributor Author

jnweiger commented Dec 2, 2020

Confirmed fixed. Only one requestor, even after multiple server resets over night.

Followup nitpick: #8275

@jnweiger jnweiger mentioned this issue Jan 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TheOneRing @jnweiger