Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build failure when pkgconfig is not available #7240

Closed
ckamm opened this issue Jun 12, 2019 · 4 comments
Closed

Fix build failure when pkgconfig is not available #7240

ckamm opened this issue Jun 12, 2019 · 4 comments
Assignees
Labels
Linux packaging ReadyToTest QA, please validate the fix/enhancement type:bug
Milestone

Comments

@ckamm
Copy link
Contributor

ckamm commented Jun 12, 2019

The cmake step of the build should succeed when the PkgConfig library can't be found. Currently the following error is shown:

 173s] -- Added vfsPlugin without tests: suffix
[  173s] Can't determine libcloudproviders version, not enabling it
[  173s] -- Could NOT find LIBCLOUDPROVIDERS (missing: LIBCLOUDPROVIDERS_LIBRARY LIBCLOUDPROVIDERS_INCLUDE_DIR) 
[  173s] CMake Error at /usr/share/cmake-3.12/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
[  173s]   Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE)
[  173s] Call Stack (most recent call first):
[  173s]   /usr/share/cmake-3.12/Modules/FindPackageHandleStandardArgs.cmake:378 (_FPHSA_FAILURE_MESSAGE)
[  173s]   /usr/share/cmake-3.12/Modules/FindPkgConfig.cmake:39 (find_package_handle_standard_args)
[  173s]   src/gui/libcloudproviders/libcloudproviders.cmake:2 (find_package)
[  173s]   src/gui/CMakeLists.txt:320 (include)
[  173s] 
[  173s] 
[  173s] -- Configuring incomplete, errors occurred!
@ckamm ckamm added type:bug ReadyToTest QA, please validate the fix/enhancement packaging Linux labels Jun 12, 2019
@ckamm ckamm added this to the 2.6.0 milestone Jun 12, 2019
@ckamm ckamm self-assigned this Jun 12, 2019
@ckamm
Copy link
Contributor Author

ckamm commented Jun 12, 2019

Seen in an automatic build by @guruz in #7235

@HanaGemela
Copy link
Contributor

@ckamm is this something QA should test? If so, please provide steps to recreate

@ckamm
Copy link
Contributor Author

ckamm commented Jul 16, 2019

@HanaGemela No, this issue is only about successfully compiling the client.

@ckamm ckamm closed this as completed Jul 16, 2019
@jnweiger
Copy link
Contributor

Linux packages have no support for libcloudproviders currently. If that feature is meant for milestone 2.6.0 then we have a blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Linux packaging ReadyToTest QA, please validate the fix/enhancement type:bug
Projects
None yet
Development

No branches or pull requests

3 participants