One broken folder stops the entire sync

[HanaGemela]

Server: 10.2.0
Client: 2.6.0-daily20190513 (build 11776)
macOS: 10.14.4

Steps to recreate:

1. Add a new account that has one broken folder on the server

Expected result: All items apart from the broken folder have been synced

Actual result: Nothing has been synced - see log below

Note: Currently working on how to recreate that broken folder on server. Once known, the issues will be linked together

[michaelstingl]

Looks like a candidate for my collection in #5859

[HanaGemela]

Follow steps 1-5 in owncloud/core#35305 to create that problematic folder

[jnweiger]

It should also be possible to poison one folder using mitmproxy with a python script that fakes a 500 response, whenever a specific folder is accessed.

[ogoffart]

What was the server error code. Looking at the error message it seems to be a 404. But 404 should not cause the sync to stop, neither should 500.
The only errors causing the sync to abort is a 503 if the server is in maintainnence, or a connection drop (connection timeout or similar)

Could you paste the log from the client?

[HanaGemela]

@ogoffart I've just emailed you the logs

[ogoffart]

Thanks for the log. I realized the problem was during the discovery and not during the propagation.

Fix PR: #7219

[HanaGemela]

The folder is not synced but it is still shown in the selective sync list as synced

[HanaGemela]

@michaelstingl please decide if it is worth the effort to fix the selective sync list

[michaelstingl]

The remaining issue is only cosmetic, so I'd close it for now.