Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress reporting shows incorrect amounts with vfs #6933

Closed
ckamm opened this issue Dec 20, 2018 · 4 comments
Closed

Progress reporting shows incorrect amounts with vfs #6933

ckamm opened this issue Dec 20, 2018 · 4 comments
Assignees
@ckamm
Labels
feature:vfs native virtual files and placeholder implementation type:bug
Milestone
2.6.0

Comments

@ckamm
Copy link
Contributor

ckamm commented Dec 20, 2018

The progress reporting isn't aware that files will not actually be downloaded and shows progress as if downloads are happening.

@hodyroff Thanks for testing!
@ckamm ckamm added type:bug feature:vfs native virtual files and placeholder implementation labels Dec 20, 2018
@ckamm ckamm added this to the 2.6.0 milestone Dec 20, 2018
@ckamm ckamm self-assigned this Dec 20, 2018
ckamm added a commit that referenced this issue Dec 20, 2018
@ckamm
Progress: Virtual file creation needs no transfer progress #6933
0390a58 
Treat virtual file creation as a size-less action, similar to
propagating renames or deletions.
@ckamm ckamm mentioned this issue Dec 20, 2018
Merged
ckamm added a commit that referenced this issue Dec 21, 2018
@ckamm
Progress: Virtual file creation needs no transfer progress #6933
979cea3 
Treat virtual file creation as a size-less action, similar to
propagating renames or deletions.
@ckamm ckamm added ReadyToTest QA, please validate the fix/enhancement and removed PR available labels Dec 21, 2018
@HanaGemela
Copy link
Contributor

@ckamm could you please specify what are the steps to test this issue? Also what is the expected result

@ckamm
Copy link
Contributor Author

ckamm commented Apr 26, 2019

@HanaGemela Enable VFS. Have a online-only folder. Add a file there on the server, say one with 100 MB. When the file is propagated by a sync (via creation of a local placeholder) the progress indicator shouldn't pretend it downloads 100 MB.

This is also noticable during initial sync.

@HanaGemela
Copy link
Contributor

Tested

Tested with 2.6.0-daily20190426 (build 11674)
Progress bar doesn’t show that it's downloading the actual 100 MB file

@HanaGemela HanaGemela removed the ReadyToTest QA, please validate the fix/enhancement label Apr 26, 2019
@HanaGemela
Copy link
Contributor

Also tested on Windows with 2.6.0daily20190425 (build 11620). The above was macOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ckamm ckamm

Labels
feature:vfs native virtual files and placeholder implementation type:bug
Projects
None yet
Milestone
2.6.0
Development

No branches or pull requests
2 participants
@ckamm @HanaGemela