Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Activity] Persist Filter Settings #10884

Closed
2 tasks done
michaelstingl opened this issue May 26, 2023 · 9 comments · Fixed by #10928, #10952, #11023 or #11065
Closed
2 tasks done

[Activity] Persist Filter Settings #10884

michaelstingl opened this issue May 26, 2023 · 9 comments · Fixed by #10928, #10952, #11023 or #11065
Assignees
@erikjv
Labels
p3-medium Normal priority
Milestone
Desktop 5.0

Comments

@michaelstingl
Copy link
Contributor

michaelstingl commented May 26, 2023 •
edited
Loading

Pre-submission Checks

  • I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
  • I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Feature description

Desktop sync client got powerful features for users to filter the activity protocol according to their needs. Only limitation is, filter settings weren't persisted, so users need to set filters again whenever they restart the client.

Proposed solution

To improver user experience, filter settings should be persisted across client restarts.

Alternative solutions you considered

No response

Additional context

CleanShot 2023-05-26 at 17 45 32@2x

testpilotcloud 5.0.0.11081-daily20230526 79bd0c
Libraries Qt 6.4.3, OpenSSL 1.1.1t 7 Feb 2023
Using virtual files plugin: suffix
macos-22.4.0
@TheOneRing TheOneRing added this to the Desktop Client 5.0 milestone May 26, 2023
@TheOneRing
Copy link
Contributor

Only persist the category filter for the sync issue table

@TheOneRing TheOneRing added p2-high Escalation, on top of current planning, release blocker p3-medium Normal priority and removed p2-high Escalation, on top of current planning, release blocker labels Jun 2, 2023
erikjv added a commit that referenced this issue Jun 14, 2023
@erikjv
Draft: Persist filter settings for Not Synced tab
553403d 
Fixes: #10884
@erikjv erikjv mentioned this issue Jun 14, 2023
Merged
erikjv added a commit that referenced this issue Jun 14, 2023
@erikjv
Persist filter settings for Not Synced tab
419c1ee 
Fixes: #10884
erikjv added a commit that referenced this issue Jun 15, 2023
@erikjv
Persist filter settings for Not Synced tab
e8f3727 
Fixes: #10884
TheOneRing pushed a commit that referenced this issue Jun 15, 2023
@erikjv @TheOneRing
Persist filter settings for Not Synced tab
8335e6e 
Fixes: #10884
@michaelstingl
Copy link
Contributor Author

CleanShot 2023-06-19 at 14 29 43 CleanShot 2023-06-19 at 14 30 08 CleanShot 2023-06-19 at 14 30 31
Filter indicator correct ✅ Empty filter indicator after restart ⚠️ Filter indicator weird after change 💥 
testpilotcloud 5.0.0.11270-daily20230619 7c55d9
Libraries Qt 6.4.3, OpenSSL 1.1.1t 7 Feb 2023
Using virtual files plugin: suffix
macos-22.5.0

@erikjv could you have another look?

@michaelstingl michaelstingl reopened this Jun 19, 2023
@erikjv
Copy link
Collaborator

erikjv commented Jun 21, 2023

Two problems here:

  1. the filter button text was not set correctly
  2. the SyncFileItem::Status::FilenameReserved enum value was not handled (it was added recently by @TheOneRing)

erikjv added a commit that referenced this issue Jun 21, 2023
@erikjv
Fix filter reloading
a05e0ad 
And also handle the `SyncFileItem::Status::FilenameReserved` enum value.

Fixes: #10884
@erikjv erikjv mentioned this issue Jun 21, 2023
Merged
erikjv added a commit that referenced this issue Jun 21, 2023
@erikjv
Fix filter reloading
280240b 
And also handle the `SyncFileItem::Status::FilenameReserved` enum value.

Fixes: #10884
erikjv added a commit that referenced this issue Jun 21, 2023
@erikjv
Fix filter reloading
25b9c6d 
And also handle the `SyncFileItem::Status::FilenameReserved` enum value.

Fixes: #10884
erikjv added a commit that referenced this issue Jun 21, 2023
@erikjv
Fix filter reloading
517a920 
And also handle the `SyncFileItem::Status::FilenameReserved` enum value.

Fixes: #10884
@S-Panta
Copy link

S-Panta commented Jul 4, 2023 •
edited by saw-jan
Loading

Tested with ownCloud 5.0.0.11377-daily20230704 511b96

Filter Indicator Correct After restart: indicator is correct but the unticked filter items are not correct ❌
1 2

Here, after restart, the blacklisted option gets ticked.

@S-Panta
Copy link

S-Panta commented Jul 4, 2023 •
edited by saw-jan
Loading

Tested with ownCloud 5.0.0.11377-daily20230704 511b96

Filter Indicator When Restored is unticked After restart:Restored is ticked ✔️
filter tag restore filter tag after logout restore

But if any of the other options are selected as a single filter tag beside Restored, that option will be ticked even after restart.

Message is unticked After restart:Message is ticked and the indicator shows 1 is unticked ❌
other tage before other option after restart

When all filter options are ticked, the filter counts go to zero after the restart.

All filter tags are unticked and filter count matches After restart: All filter tags are ticked and no count is shown ❌
all options before all option after restart

Many other similar sorts of mismatches are found between the indicator of the filter tag and the item unticked in the drop menu.

cc @erikjv

@S-Panta S-Panta reopened this Jul 4, 2023
erikjv added a commit that referenced this issue Jul 10, 2023
@erikjv
Fix persisting filter settings in activity tab
41f02d2 
There were two issues: first, the StatusSet was not initialised, thus
containing random values. Second, no difference was made between an
empty filter list, and an absent filter list (the latter would cause
the filter to be reset). Both are fixed now.

Fixes: #10884
@erikjv erikjv linked a pull request Jul 10, 2023 that will close this issue
Fix persisting filter settings in activity tab #11023
Merged
erikjv added a commit that referenced this issue Jul 11, 2023
@erikjv
Fix persisting filter settings in activity tab
47c36f5 
There were two issues: first, the StatusSet was not initialised, thus
containing random values. Second, no difference was made between an
empty filter list, and an absent filter list (the latter would cause
the filter to be reset). Both are fixed now.

Fixes: #10884
@S-Panta
Copy link

S-Panta commented Jul 18, 2023

Tested with ownCloud 5.0.0.11486-daily20230718 [8d6b84]

Filter Indicator Before Restart ✔️ After restart:Filter indicator remains same ✔️
Screenshot from 2023-07-18 14-53-50 Screenshot from 2023-07-18 14-54-14

@Salipa-Gurung Salipa-Gurung mentioned this issue Jul 19, 2023
Merged
@michaelstingl
Copy link
Contributor Author

@erikjv when I select an account, it has no checkmark-indicator:

CleanShot 2023-07-25 at 15 07 24@2x

testpilotcloud 5.0.0.11536-daily20230724 d763b9
Libraries Qt 6.4.3, OpenSSL 3.1.1 30 May 2023
Using virtual files plugin: suffix
macos-22.5.0

@michaelstingl michaelstingl reopened this Jul 25, 2023
@michaelstingl
Copy link
Contributor Author

michaelstingl commented Jul 25, 2023 •
edited
Loading

Additionally:

Account Filter setting isn't persisted after quit&restart. Always switches back to "✔️ All" ⚠️

EDIT: No need to change – persisting filtering by account feels unintuitive.

erikjv added a commit that referenced this issue Jul 27, 2023
@erikjv
Fix account check marks in filter menu
fd698f4 
The filter is a regular expression pattern, so compare it to the
escaped version of the filter string.

Fixes: #10884
@michaelstingl michaelstingl linked a pull request Jul 27, 2023 that will close this issue
Fix account check marks in filter menu #11065
Merged
@michaelstingl michaelstingl mentioned this issue Jul 27, 2023
Merged
fmoc pushed a commit that referenced this issue Jul 31, 2023
@erikjv @fmoc
Fix account check marks in filter menu
8a041f4 
The filter is a regular expression pattern, so compare it to the
escaped version of the filter string.

Fixes: #10884
@HanaGemela
Copy link
Contributor

Passed. Checkmark-indicator available in ownCloud 5.0.0.11624-daily20230801

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erikjv erikjv

Labels
p3-medium Normal priority
Projects
None yet
Milestone
Desktop 5.0
5 participants
@erikjv @TheOneRing @michaelstingl @HanaGemela @S-Panta