Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add brandable button in top toolbar #10518

Closed
2 tasks done
fmoc opened this issue Feb 20, 2023 · 6 comments · Fixed by #10597 or #10640
Closed
2 tasks done

Add brandable button in top toolbar #10518

fmoc opened this issue Feb 20, 2023 · 6 comments · Fixed by #10597 or #10640
Assignees
@TheOneRing @HanaGemela
Labels
Needs info p2-high Escalation, on top of current planning, release blocker
Milestone
Desktop Client 4.0

Comments

@fmoc
Copy link
Contributor

fmoc commented Feb 20, 2023

Pre-submission Checks

  • I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
  • I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Feature description

Some of our customers may want to add a custom button to the toolbar in the settings window to, e.g., open a link in the browser.

Proposed solution

See the screenshot:

screenshot_2023-02-20_12-16-55

Alternative solutions you considered

The button could be placed anywhere, really. Three properties should be configurable through branding parameters:

  • button logo (possibly different icons for dark and light modes)
  • button text
  • button action (or just URL)

Additional context

No response
@fmoc fmoc added the p2-high Escalation, on top of current planning, release blocker label Feb 20, 2023
@fmoc fmoc added this to the 4.0 milestone Feb 20, 2023
@TheOneRing TheOneRing self-assigned this Mar 14, 2023
TheOneRing added a commit that referenced this issue Mar 15, 2023
@TheOneRing
Branding: urlButtons
258ffa5 
A list of Text, Url pairs that define additional toolbar buttons.

Fixes: #10518
@TheOneRing TheOneRing mentioned this issue Mar 15, 2023
Merged
TheOneRing added a commit that referenced this issue Mar 15, 2023
@TheOneRing
Branding: urlButtons (#10597)
3ce36ca 
A list of Text, Url pairs that define additional toolbar buttons.

Fixes: #10518
@HanaGemela HanaGemela self-assigned this Mar 24, 2023
@TheOneRing TheOneRing reopened this Mar 28, 2023
@TheOneRing
Copy link
Contributor

We need to support arbitrary subtitles, so using the title for the icon was a bit short sighted.

@TheOneRing TheOneRing linked a pull request Mar 28, 2023 that will close this issue
urlButtons: Allow icon name to differ from icon description #10640
Merged
@michaelstingl
Copy link
Contributor

Example theming commit for testing:

@HanaGemela
Copy link
Contributor

HanaGemela commented Apr 4, 2023 •
edited
Loading

The button is there in qa 4.0.0.10572-daily20230404, mac and also windows

@rizlas
Copy link

rizlas commented Aug 24, 2023

Is this available in ownBrander?

@TheOneRing
Copy link
Contributor

Is this available in ownBrander?

No

@michaelstingl
Copy link
Contributor

Is this available in ownBrander?

No

Please get in touch with ownCloud support team for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheOneRing TheOneRing

@HanaGemela HanaGemela

Labels
Needs info p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Milestone
Desktop Client 4.0
6 participants
@TheOneRing @michaelstingl @rizlas @HanaGemela @saw-jan @fmoc