Windows client forces folder icon to be owncloud icon

[nextMJ]

Pre-submission Checks

• I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
• I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Describe the bug

In version 3.0.0.9215 (do not know from which it was upgraded but I keep all SW up to date) the new feature forces the synced folder icon to be owncloud icon. When I change it manually, it forces the behavior at the next start again. My synced folders are forced to look like this:

Instead of:

The behavior affects only the root folder which is synced and not the subfolders.

Expected behavior

I would expect that OC will set these icons ONLY at the first installation process (and maybe when the user creates a new sync folder). When the user does not want to have this behavior, he can change it manually and it will stay as he would prefer.

Ideally, the installer could ask about changing the icons to OC or keep it default.

Steps to reproduce the issue

No response

Screenshots

No response

Logs

No response

Client version number

ownCloud 3.0.0.9215- 457b08
Libraries Qt 5.15.5, OpenSSL 1.1.1q 5 Jul 2022
Using virtual files plugin: wincfapi
windows-10.0.19045

Desktop environment (Linux only)

No response

Client package version and origin (Linux only)

No response

Installation path (Windows only)

C:\Program Files (x86)\ownCloud

Server information

No response

Additional context

No response

[light]

I also noticed this behaviour in the 3.0.0 release. This seems related to this change : #10184. Previously it used to only set the desktop.ini when a folder is setup and not overwrite it if it already exists, now it replaces the icon everytime the client is started.

It would be nice to have a setting to disable changing the folder icons, the overlay icons are enough for me.

I found a workaround in the meantime : set the folder as you like in explorer, then set the desktop.ini file readonly in a command prompt with attrib +R +H +S desktop.ini

[buracek]

@light Thank for this solution, but it did not solve all troubles. In my case new version of OwnCloud changes not only icons but all synced folders are changed to hidden. I can see them normally in file explorer but not in Altap Salamander and in some specific SW i am using (ArcGIS Pro). Readonly will change only how the folder looks like but not the "hidden settings". Any other tip how to solve it?

[michaelstingl]

In my case new version of OwnCloud changes not only icons but all synced folders are changed to hidden. I can see them normally in file explorer but not in Altap Salamander and in some specific SW i am using (ArcGIS Pro).

Please open a separate issue about this, then the team can have a look.

[schimschewski]

I also noticed this behaviour in the 3.0.0 release. This seems related to this change : #10184. Previously it used to only set the desktop.ini when a folder is setup and not overwrite it if it already exists, now it replaces the icon everytime the client is started.

It would be nice to have a setting to disable changing the folder icons, the overlay icons are enough for me.

I found a workaround in the meantime : set the folder as you like in explorer, then set the desktop.ini file readonly in a command prompt with attrib +R +H +S desktop.ini

unfortunately it does not work for me. the icon is still overwritten. any other hints?

[github-actions]

This issue was marked stale because it has been open for 30 days with no activity. Remove the stale label or comment or this will be closed in 7 days.

[nextMJ]

Still the same troubles even with the latest update (3.2.1.10355 9724d6)

[saw-jan]

Tested with ownCloud 3.2.1.10355 9724d6
OS: Win10

Test with 4.0 daily

1. First install ✔️	2. Changing icon	3. icon changed ✔️

4. After Client Quit and Re-open ✔️	5. After system restart ❌

[TheOneRing]

@saw-jan Please have a look on the implementation. See the description of
#10592 (comment)

[saw-jan]

Sorry, I also have tested with older client. Must test with 4.0 daily

[saw-jan]

Tested with ownCloud 4.0.0.10422-daily20230316 8e8490

Steps:

1. Change the folder icon
2. Set UpdateIcon=false in Desktop.ini

[ownCloud]
UpdateIcon=false

1. Fresh install ✔️	2. Change the folder icon	3. Custom icon ✔️

4. Set UpdateIcon=false	5. After system restart, custom icon persists ✔️