Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac: 'Remove all files dialog' selected button has the wrong color #10254

Closed
2 tasks done
HanaGemela opened this issue Nov 9, 2022 · 6 comments · Fixed by #10646
Closed
2 tasks done

Mac: 'Remove all files dialog' selected button has the wrong color #10254

HanaGemela opened this issue Nov 9, 2022 · 6 comments · Fixed by #10646

Comments

@HanaGemela
Copy link
Contributor

HanaGemela commented Nov 9, 2022

Pre-submission Checks

  • I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
  • I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Describe the QA issue

Option to 'Delete all' is highlighted. More user friendly would be to highlight the option to 'Keep files'
mac client 3.0.0 beta 1
ocis 2.0.0 rc1

Steps to reproduce the issue

  1. Create a Space on the server with some files
  2. Sync the Space to the client
  3. Rename the Space folder in the Finder
  4. Create a new folder with the name of Space in the Finder

Screenshots

Screenshot 2022-11-09 at 12 59 14

Expected behavior

Option 'Keep files' is highlighted

Actual behavior

Option 'Remove all files' is highlighted

@HanaGemela HanaGemela added this to the 3.1 milestone Nov 9, 2022
@TheOneRing TheOneRing changed the title [QA] The dialog highlights 'Remove all files' option instead of 'Keep files' [QA] The dialog defaults to 'Remove all files' option instead of 'Keep files' Nov 18, 2022
@fmoc fmoc self-assigned this Dec 1, 2022
@fmoc fmoc modified the milestones: 3.1, 4.0 Dec 1, 2022
@fmoc

This comment was marked as resolved.

@TheOneRing TheOneRing added p3-medium Normal priority and removed p4-low Low priority labels Jan 19, 2023
@TheOneRing TheOneRing assigned TheOneRing and unassigned fmoc Mar 29, 2023
TheOneRing added a commit that referenced this issue Mar 29, 2023
TheOneRing added a commit that referenced this issue Mar 29, 2023
@HanaGemela
Copy link
Contributor Author

Failed ownCloud 4.0.0.10542-daily20230331, mac

@HanaGemela HanaGemela reopened this Mar 31, 2023
@HanaGemela
Copy link
Contributor Author

The 'Keeps files' is dark grey. The dialog is not active so the button is not blue also after clicking it

@TheOneRing
Copy link
Contributor

Apparently the selection was correct the whole time, setting the default action explicitly however doesn't hurt.
The issue here is that on mac the window appears not properly activated and thus the default action is drawn in the inactive state "grey" instead of "blue".

@TheOneRing TheOneRing added p4-low Low priority and removed p3-medium Normal priority labels Mar 31, 2023
@TheOneRing TheOneRing changed the title [QA] The dialog defaults to 'Remove all files' option instead of 'Keep files' Mac: 'Remove all files dialog' selected button has the wrong color Apr 5, 2023
@TheOneRing TheOneRing modified the milestones: Desktop Client 5.0, inbox Apr 13, 2023
@TheOneRing
Copy link
Contributor

Please retest with the current version of the client

@HanaGemela
Copy link
Contributor Author

Passed in ownCloud 5.0.0.11999-daily20230901 mac

Screenshot 2023-09-01 at 09 52 15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants