Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add retry_if support on steps #490

Merged
merged 5 commits into from
Jan 22, 2022
Merged

feat: add retry_if support on steps #490

merged 5 commits into from
Jan 22, 2022

Conversation

lowlighter
Copy link
Member

Closes #458

Add support for retry_if to perform retries only while certains conditions are met.

Preview:
image

Signed-off-by: GitHub <[email protected]>
@ovh-cds

This comment has been minimized.

Signed-off-by: GitHub <[email protected]>
@ovh-cds

This comment has been minimized.

Signed-off-by: GitHub <[email protected]>
@ovh-cds

This comment has been minimized.

Signed-off-by: GitHub <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

70.6% 70.6% Coverage
0.0% 0.0% Duplication

@lowlighter lowlighter requested review from fsamin and yesnault January 18, 2022 22:50
@lowlighter
Copy link
Member Author

I think some the tests/interpolation is not deterministic and should be either removed or patched:
image

running it 10 times in a row without any changes yield different results

Copy link
Member

@fsamin fsamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx a lot
LGTM

Copy link
Member

@yesnault yesnault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yesnault yesnault merged commit 7695b81 into master Jan 22, 2022
@fsamin fsamin deleted the feat-retry-if branch January 25, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: add a fail-fast mechanic to assertions
4 participants