Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (dbaas/logs) role & permission #859

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Conversation

131
Copy link
Contributor

@131 131 commented Feb 21, 2025

Description

This pull request adds 2 new resources (and related documentation)

  • ovh_dbaas_logs_role (bound to /dbaas/logs/{serviceName}/role )
  • ovh_dbaas_logs_role_permission (bound to GET /dbaas/logs/{serviceName}/role/{roleId}/permission)

With documentation and import capabilities (for the role)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Improvement (improve existing resource(s) or datasource(s))
  • Documentation update

@131 131 requested a review from a team as a code owner February 21, 2025 17:35
@131 131 changed the title With role & permission feat: (dbaas/logs) role & permission Feb 21, 2025
Copy link
Contributor

@amstuta amstuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @131 ! Apart from the comments I left, ok to merge.

@131
Copy link
Contributor Author

131 commented Feb 26, 2025

Un instant, j'avais compris que log_permission etait "trop ambitieux" quand la seule gestion de log_permission_stream etait ce dont je voulais /pouvais m'occuper. Mais qu'il allait alors falloir que je renomme tout, et j'ai eu la #flemme.

Bon, c'est pas passé à la relecture, mais j'avais tenté quand même.
Modifications effectuées.

@amstuta amstuta merged commit 76bdaec into ovh:master Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants