chore: Uppercase flavors when searching for savings plans in resource ovh_savings_plan #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amstuta
requested review from
rbeuque74,
deathiop,
mxpetit and
marie-j
as code owners
mxpetit
previously approved these changes
Jan 10, 2025
marie-j
reviewed
Jan 10, 2025
| @@ -24,7 +24,7 @@ resource "ovh_savings_plan" "plan" { | |||
| The following arguments are supported: | |||
|
|
|||
| * `service_name` - (Required) ID of the public cloud project | |||
| * `flavor` - (Required) Savings Plan flavor (e.g. Rancher, C3-4, any instance flavor, ...) | |||
| * `flavor` - (Required) Savings Plan flavor (e.g. Rancher, C3-4, any instance flavor, ...). **The flavor for instances must be uppercased**. | |||
There was a problem hiding this comment.
Suggested change
| * `flavor` - (Required) Savings Plan flavor (e.g. Rancher, C3-4, any instance flavor, ...). **The flavor for instances must be uppercased**. | |
| * `flavor` - (Required) Savings Plan flavor (e.g. Rancher, C3-4, any instance flavor, ...). **Instances flavors must be uppercased**. |
… ovh_savings_plan
amstuta
force-pushed
the
dev/aamstutz/update-savings-plans-doc
branch
from
976dd1a to
683c902
Compare
amstuta
changed the title
deathiop
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #798
Type of change