-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add efiBootloaderPath for dedicated server resource & update #755
Conversation
a751156
to
ac7d0b5
Compare
I think you forgot to update resource |
e75cf46
to
ed94aa5
Compare
8fcf9ba
to
e66d2e1
Compare
@@ -130,7 +137,7 @@ func TestAccDedicatedServer_basic(t *testing.T) { | |||
ImportStateVerify: true, | |||
ImportStateVerifyIdentifierAttribute: "service_name", | |||
ImportStateVerifyIgnore: []string{ | |||
"display_name", "order", "ovh_subsidiary", "plan", "plan_option", "template_name", | |||
"display_name", "order", "ovh_subsidiary", "plan", "plan_option", "template_name", "efi_bootloader_path", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this field is returned by the API and should thus be read when importing the resource, why would you ignore it ?
0b469c8
to
19f292b
Compare
19f292b
to
6d7b4f1
Compare
6d7b4f1
to
08e0f10
Compare
ac882c2
to
04ead1a
Compare
04ead1a
to
4b3e514
Compare
@@ -88,10 +88,6 @@ func TestAccDedicatedServerInstall_usermetadata(t *testing.T) { | |||
{ | |||
Config: testAccDedicatedServerInstallConfig("usermetadata"), | |||
Check: resource.ComposeTestCheckFunc( | |||
resource.TestCheckResourceAttr( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you need to remove these fields from the test ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test was failing but it's ok now, restored
4b3e514
to
1e17339
Compare
Add efiBootloaderPath for dedicated server resource & dedicated server update
Description
Possibility to GET and PUT the efi_bootloader_path on a dedicated server
Fixes #xx (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
make testacc TESTARGS="-run TestAccDedicatedServerDataSource_basic"
Test Configuration:
terraform version
: Terraform 1.6.6Checklist:
go mod vendor
if I added or modifygo.mod
file