Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add efiBootloaderPath for dedicated server resource & update #755

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

bigbigbang
Copy link
Contributor

@bigbigbang bigbigbang commented Oct 17, 2024

Add efiBootloaderPath for dedicated server resource & dedicated server update

Description

Possibility to GET and PUT the efi_bootloader_path on a dedicated server

Fixes #xx (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Improvement (improve existing resource(s) or datasource(s))
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A: make testacc TESTARGS="-run TestAccDedicatedServerDataSource_basic"
  • make testacc TESTARGS="-run TestAccDedicatedServerUpdate_basic"

Test Configuration:

  • Terraform version: terraform version: Terraform 1.6.6
  • Existing HCL configuration you used:
resource "" "" {
a dedicated serer
}

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran succesfully go mod vendor if I added or modify go.mod file

@bigbigbang bigbigbang marked this pull request as draft October 17, 2024 13:57
@bigbigbang bigbigbang force-pushed the dedicated_server_add_efiBootloaderPath branch from a751156 to ac7d0b5 Compare October 17, 2024 14:02
@bigbigbang bigbigbang marked this pull request as ready for review October 17, 2024 14:03
@amstuta
Copy link
Contributor

amstuta commented Oct 18, 2024

I think you forgot to update resource ovh_dedicated_server (I see you updated the doc but not the resource itself)

@bigbigbang bigbigbang force-pushed the dedicated_server_add_efiBootloaderPath branch 2 times, most recently from e75cf46 to ed94aa5 Compare October 24, 2024 14:21
@bigbigbang bigbigbang marked this pull request as draft October 24, 2024 14:21
@bigbigbang bigbigbang force-pushed the dedicated_server_add_efiBootloaderPath branch 2 times, most recently from 8fcf9ba to e66d2e1 Compare October 24, 2024 16:01
@@ -130,7 +137,7 @@ func TestAccDedicatedServer_basic(t *testing.T) {
ImportStateVerify: true,
ImportStateVerifyIdentifierAttribute: "service_name",
ImportStateVerifyIgnore: []string{
"display_name", "order", "ovh_subsidiary", "plan", "plan_option", "template_name",
"display_name", "order", "ovh_subsidiary", "plan", "plan_option", "template_name", "efi_bootloader_path",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this field is returned by the API and should thus be read when importing the resource, why would you ignore it ?

@bigbigbang bigbigbang force-pushed the dedicated_server_add_efiBootloaderPath branch 12 times, most recently from 0b469c8 to 19f292b Compare October 29, 2024 14:19
@bigbigbang bigbigbang force-pushed the dedicated_server_add_efiBootloaderPath branch from 19f292b to 6d7b4f1 Compare January 16, 2025 13:21
@bigbigbang bigbigbang force-pushed the dedicated_server_add_efiBootloaderPath branch from 6d7b4f1 to 08e0f10 Compare January 29, 2025 16:20
@bigbigbang bigbigbang force-pushed the dedicated_server_add_efiBootloaderPath branch 6 times, most recently from ac882c2 to 04ead1a Compare January 31, 2025 13:16
@bigbigbang bigbigbang marked this pull request as ready for review January 31, 2025 13:33
@bigbigbang bigbigbang requested a review from a team as a code owner January 31, 2025 13:33
@bigbigbang bigbigbang force-pushed the dedicated_server_add_efiBootloaderPath branch from 04ead1a to 4b3e514 Compare January 31, 2025 13:59
@@ -88,10 +88,6 @@ func TestAccDedicatedServerInstall_usermetadata(t *testing.T) {
{
Config: testAccDedicatedServerInstallConfig("usermetadata"),
Check: resource.ComposeTestCheckFunc(
resource.TestCheckResourceAttr(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you need to remove these fields from the test ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test was failing but it's ok now, restored

@bigbigbang bigbigbang force-pushed the dedicated_server_add_efiBootloaderPath branch from 4b3e514 to 1e17339 Compare February 3, 2025 09:57
@amstuta amstuta merged commit 50b8eb0 into master Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants