Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datasource volume(s) #736

Merged
merged 5 commits into from
Oct 11, 2024
Merged

datasource volume(s) #736

merged 5 commits into from
Oct 11, 2024

Conversation

Tiboau
Copy link
Contributor

@Tiboau Tiboau commented Oct 1, 2024

Description

Get or List volumes from public cloud

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (improve existing resource(s) or datasource(s))
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A:
export OVH_CLOUD_PROJECT_SERVICE_TEST=""
export OVH_CLOUD_PROJECT_REGION_TEST = ""
export OVH_CLOUD_PROJECT_VOLUME_ID_TEST = ''
make testacc TESTARGS="-run TestAccDataCloudProjectVolumes_basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccDataCloudProjectVolumes_basic -timeout 600m -p 10
?       github.com/ovh/terraform-provider-ovh   [no test files]
?       github.com/ovh/terraform-provider-ovh/ovh/helpers       [no test files]
?       github.com/ovh/terraform-provider-ovh/ovh/types [no test files]
testing: warning: no tests to run
PASS
ok      github.com/ovh/terraform-provider-ovh/ovh       (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/ovh/terraform-provider-ovh/ovh/helpers/hashcode      (cached) [no tests to run]"
  • Test B:
export OVH_CLOUD_PROJECT_SERVICE_TEST=""
export OVH_CLOUD_PROJECT_REGION_TEST = ""
make testacc TESTARGS="-run TestAccDataCloudProjectVolume_basic" 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccDataCloudProjectVolume_basic -timeout 600m -p 10
?       github.com/ovh/terraform-provider-ovh   [no test files]
?       github.com/ovh/terraform-provider-ovh/ovh/helpers       [no test files]
?       github.com/ovh/terraform-provider-ovh/ovh/types [no test files]
testing: warning: no tests to run
PASS
ok      github.com/ovh/terraform-provider-ovh/ovh       (cached) [no tests to run]
testing: warning: no tests to run
PASS
ok      github.com/ovh/terraform-provider-ovh/ovh/helpers/hashcode      (cached) [no tests to run]"

Test Configuration:

  • Terraform version: terraform version: Terraform v1.5.7
  • Existing HCL configuration you used:
data "ovh_cloud_project_volumes" "volumes" {
   region_name = "xxx"
   service_name = "yyyyyyyyyyyyyyyyy"
}

data "ovh_cloud_project_volume" "vol" {
   region_name = "xxx"
   service_name = "yyyyyyyyyyyyyyyyy"
   volume_id = "aaaaaaaa-bbbb-cccc-dddd-eeeeeeee"
}

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran succesfully go mod vendor if I added or modify go.mod file

mxpetit
mxpetit previously requested changes Oct 1, 2024
Copy link

@mxpetit mxpetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also make sure the tests will be run on each modification by editing the terraform-provider-ovh.yml file?

@amstuta amstuta closed this Oct 11, 2024
@amstuta amstuta reopened this Oct 11, 2024
@amstuta amstuta merged commit b8e9462 into ovh:master Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants