-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
subnet v2 resource (regionalized API) #732
Merged
amstuta
merged 5 commits into
ovh:master
from
AdrienPensart:dev/adrien.pensart/private-subnet-dhcp-attributes
Oct 2, 2024
Merged
subnet v2 resource (regionalized API) #732
amstuta
merged 5 commits into
ovh:master
from
AdrienPensart:dev/adrien.pensart/private-subnet-dhcp-attributes
Oct 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8974b2a
to
f545853
Compare
f545853
to
9b890ca
Compare
9b890ca
to
04df2ad
Compare
amstuta
requested changes
Sep 26, 2024
}, | ||
"enable_gateway_ip": { | ||
Type: schema.TypeBool, | ||
Optional: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
required on the API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to set as required
website/docs/r/cloud_project_network_private_subnet_v2.html.markdown
Outdated
Show resolved
Hide resolved
amstuta
requested changes
Oct 1, 2024
website/docs/r/cloud_project_network_private_subnet_v2.html.markdown
Outdated
Show resolved
Hide resolved
website/docs/r/cloud_project_network_private_subnet_v2.html.markdown
Outdated
Show resolved
Hide resolved
amstuta
reviewed
Oct 2, 2024
amstuta
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new regionalized resource ovh_cloud_project_network_private_subnet_v2, it is not really a v2, but a regionalized subnet, so it may be preferable to call it ovh_cloud_project_network_private_subnet_on_region or something like this...
Related to ovh/public-cloud-roadmap#582
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
make testacc TESTARGS="-run TestAccCloudProjectNetworkPrivateSubnetV2_basic"
Test Configuration:
terraform version
: Terraform vx.y.zChecklist:
go mod vendor
if I added or modifygo.mod
file