Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider for okms service #709

Merged
merged 14 commits into from
Sep 12, 2024
Merged

Conversation

rcatolino
Copy link

Description

This adds the possibility to order a KMS and create credentials and service keys.

I broke down the PR into multiple commits for the datasource/resources/tests. So it should be possible to review/test these independently.

I had to update the terraform-plugin-testing to v1.10 to be able to use the [compare](https://developer.hashicorp.com/terraform/plugin/testing/acceptance-tests/state-checks/resource#comparevalue-state-check) feature in the tests.

Type of change

  • [x ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Test A: make testacc TESTARGS="-run TestAccOkms"
  • Test B: OVH_OKMS=<kms id> make testacc TESTARGS="-run TestAccOkmsImport
  • Test C: OVH_OKMS=<kms id> OVH_OKMS_CREDENTIAL=<cred id> make testacc TESTARGS="-run TestAccOkmsCredImport

(The last 2 tests need to have a kms and a credential already created on the account used for the tests, so they are skipped in the CDS pipeline)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran succesfully go mod vendor if I added or modify go.mod file

Raphael Catolino added 3 commits September 5, 2024 16:42
* Move updateServiceDisplayName to services
* Add a few plan modifiers that were missing
@amstuta amstuta merged commit 0ed2788 into ovh:master Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants