-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add provider for okms service #709
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a0c4882
to
16561e5
Compare
amstuta
reviewed
Sep 5, 2024
* Move updateServiceDisplayName to services * Add a few plan modifiers that were missing
Galiley
reviewed
Sep 5, 2024
amstuta
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds the possibility to order a KMS and create credentials and service keys.
I broke down the PR into multiple commits for the datasource/resources/tests. So it should be possible to review/test these independently.
I had to update the terraform-plugin-testing to v1.10 to be able to use the
[compare](https://developer.hashicorp.com/terraform/plugin/testing/acceptance-tests/state-checks/resource#comparevalue-state-check)
feature in the tests.Type of change
How Has This Been Tested?
make testacc TESTARGS="-run TestAccOkms"
OVH_OKMS=<kms id> make testacc TESTARGS="-run TestAccOkmsImport
OVH_OKMS=<kms id> OVH_OKMS_CREDENTIAL=<cred id> make testacc TESTARGS="-run TestAccOkmsCredImport
(The last 2 tests need to have a kms and a credential already created on the account used for the tests, so they are skipped in the CDS pipeline)
Checklist:
go mod vendor
if I added or modifygo.mod
file