Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iplb): add support for deniedSource on tcp frontends #652

Merged
merged 1 commit into from
May 21, 2024

Conversation

rcatolino
Copy link

Description

Adds support for the deniedSource parameter on the IPLB tcp frontends

Type of change

  • Improvement (improve existing resource(s) or datasource(s))

How Has This Been Tested?

Tested update/refresh on my IPLB LB2 with configuration :

Test Configuration:

  • Terraform version: terraform version: Terraform v1.8.1
  • Existing HCL configuration you used:
resource "ovh_iploadbalancing_tcp_frontend" "frontend-rest-kmip" {
  service_name    = data.ovh_iploadbalancing.iplb-a.service_name
  display_name    = "${var.lbname}"
  zone                  = var.region
  port                   = "${var.rest_api_port}"
  ssl                     = false
  default_farm_id = ovh_iploadbalancing_tcp_farm.farm.id
  allowed_source = var.allowed_sources                                                                               
  denied_source  = length(var.allowed_sources) == 0 ? var.denied_sources : []
}

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran succesfully go mod vendor if I added or modify go.mod file

@amstuta
Copy link
Contributor

amstuta commented May 21, 2024

Thanks for your contribution @rcatolino ! Could you also add the deniedSource parameter in the doc here: https://github.com/ovh/terraform-provider-ovh/blob/master/website/docs/r/iploadbalancing_tcp_frontend.html.markdown ?

@rcatolino rcatolino force-pushed the feat/add_iplb_frontend_denied_source branch from 8a56ac7 to 64d4163 Compare May 21, 2024 10:16
@amstuta amstuta merged commit 5a5054b into ovh:master May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants