manage admin user for mongodb + use ValidateDiagFunc #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpatte
requested review from
rbeuque74,
deathiop,
a-beudin,
amstuta,
mxpetit and
yomovh
as code owners
amstuta
reviewed
Apr 8, 2024
| return func(v any, p cty.Path) (diags diag.Diagnostics) { | ||
| err := ValidateStringEnum(v.(string), enum) | ||
| if err != nil { | ||
| diags = append(diags, diag.Diagnostic{ |
There was a problem hiding this comment.
note: you could just use diags.AddError()
There was a problem hiding this comment.
"terraform-plugin-framework/diag" has it not "terraform-plugin-sdk/v2/diag"
ovh/types_cloud_project_database.go
Outdated
| diags = append(diags, diag.Diagnostic{ | ||
| Severity: diag.Error, | ||
| Summary: "Missing authentication database", | ||
| Detail: fmt.Sprintf("value %s do not have authentication database", value), |
There was a problem hiding this comment.
Suggested change
| Detail: fmt.Sprintf("value %s do not have authentication database", value), | |
| Detail: fmt.Sprintf("value %s does not have authentication database", value), |
| if err := config.OVHClient.GetWithContext(ctx, listEndpoint, &listRes); err != nil { | ||
| return diag.Errorf("Error calling GET %s:\n\t %q", listEndpoint, err) | ||
| } | ||
|
|
||
| name := d.Get("name").(string) | ||
| if name == "admin" { |
There was a problem hiding this comment.
can you really get there considering this line: https://github.com/ovh/terraform-provider-ovh/pull/609/files#diff-914dfbdacc3d33ba986c5cc7c2ec9931d84789eb769aec8102c606e0a82d07c5R31 ?
There was a problem hiding this comment.
Yes because the special case for user admin in ovh/resource_cloud_project_database_mongodb_user.go will call ovh/data_cloud_project_database_mongodb_user.go:dataSourceCloudProjectDatabaseMongodbUserRead() with name = "admin"
|
|
||
| * `name` - (Required, Forces new resource) Name of the user. | ||
|
|
||
| * `name` - (Required, Forces new resource) Name of the user. A user named "admin" is map with already created admin@admin user instead of create a new user. |
There was a problem hiding this comment.
Suggested change
| * `name` - (Required, Forces new resource) Name of the user. A user named "admin" is map with already created admin@admin user instead of create a new user. | |
| * `name` - (Required, Forces new resource) Name of the user. A user named "admin" is mapped with already created admin@admin user instead of creating a new user. |
amstuta
reviewed
Apr 9, 2024
|
|
||
| * `name` - (Required, Forces new resource) Name of the user. A user named "avnadmin" is map with already created admin user instead of create a new user. | ||
|
|
||
| * `name` - (Required, Forces new resource) Name of the user. A user named "avnadmin" is map with already created admin user instead of creating a new user. |
There was a problem hiding this comment.
Suggested change
| * `name` - (Required, Forces new resource) Name of the user. A user named "avnadmin" is map with already created admin user instead of creating a new user. | |
| * `name` - (Required, Forces new resource) Name of the user. A user named "avnadmin" is mapped with already created admin user instead of creating a new user. |
|
|
||
| * `name` - (Required, Forces new resource) Username affected by this acl. A user named "avnadmin" is map with already created admin user and reset his password instead of create a new user. | ||
|
|
||
| * `name` - (Required, Forces new resource) Username affected by this acl. A user named "avnadmin" is map with already created admin user and reset his password instead of creating a new user. |
There was a problem hiding this comment.
Suggested change
| * `name` - (Required, Forces new resource) Username affected by this acl. A user named "avnadmin" is map with already created admin user and reset his password instead of creating a new user. | |
| * `name` - (Required, Forces new resource) Username affected by this acl. A user named "avnadmin" is mapped with already created admin user and reset his password instead of creating a new user. |
|
|
||
| * `name` - (Required, Forces new resource) Name of the user. A user named "avnadmin" is map with already created admin user and reset his password instead of create a new user. | ||
|
|
||
| * `name` - (Required, Forces new resource) Name of the user. A user named "avnadmin" is map with already created admin user and reset his password instead of creating a new user. |
There was a problem hiding this comment.
Suggested change
| * `name` - (Required, Forces new resource) Name of the user. A user named "avnadmin" is map with already created admin user and reset his password instead of creating a new user. | |
| * `name` - (Required, Forces new resource) Name of the user. A user named "avnadmin" is mapped with already created admin user and reset his password instead of creating a new user. |
|
|
||
| * `name` - (Required, Forces new resource) Name of the user. A user named "avnadmin" is map with already created admin user and reset his password instead of create a new user. The "Grafana" engine only allows the "avnadmin" mapping. | ||
|
|
||
| * `name` - (Required, Forces new resource) Name of the user. A user named "avnadmin" is map with already created admin user and reset his password instead of creating a new user. The "Grafana" engine only allows the "avnadmin" mapping. |
There was a problem hiding this comment.
Suggested change
| * `name` - (Required, Forces new resource) Name of the user. A user named "avnadmin" is map with already created admin user and reset his password instead of creating a new user. The "Grafana" engine only allows the "avnadmin" mapping. | |
| * `name` - (Required, Forces new resource) Name of the user. A user named "avnadmin" is mapped with already created admin user and reset his password instead of creating a new user. The "Grafana" engine only allows the "avnadmin" mapping. |
amstuta
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Manage mongodb admin user like avnadmin user for other engines
Related #588 (issue)
Type of change
Please delete options that are not relevant.