rework connection pool #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpatte
requested review from
rbeuque74,
deathiop,
a-beudin,
amstuta,
mxpetit and
yomovh
as code owners
amstuta
reviewed
Apr 8, 2024
| log.Printf("[DEBUG] Will create connection pool: %+v for cluster %s from project %s", params, clusterID, serviceName) | ||
| rErr := config.OVHClient.PostWithContext(ctx, endpoint, params, res) | ||
| if rErr != nil { | ||
| if errOvh, ok := rErr.(*ovh.APIError); ok && (errOvh.Code == 403) { |
There was a problem hiding this comment.
we want to retry in case of a 403 ? I think this deserves a comment as it's kind of weird
There was a problem hiding this comment.
Yes this is the error code when the database is not create yet :
OVHcloud API error (status code 403): Client::Forbidden::BadRequest: {"errors":[{"message":"Service database 'mydatabase' does not exist","status":403}],"message":"Service database 'mydatabase' does not exist"}
amstuta
reviewed
Apr 8, 2024
| output "connection_pool_ids" { | ||
| value = data.ovh_cloud_project_database_postgresql_connection_pools.test_pools.connection_pool_ids | ||
| } | ||
|
|
amstuta
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Please delete options that are not relevant.