feat(pci cloud db) - add ovh_cloud_project_database_postgresql_connection_pool resource & …

[julianguinard]

Description

This adds a new add ovh_cloud_project_database_postgresql_connection_pool resource & datasource to manage Public Cloud Databases postgresql connection pools

It relies on /cloud/project/{serviceName}/database/postgresql/{clusterId}/connectionPool/* APIV6 routes:

Type of change

• New feature (non-breaking change which adds functionality)
• Documentation update

How Has This Been Tested?

• Test :

make testacc TESTARGS="-run TestAccCloudProjectDatabasePostgresqlConnectionPool_importBasic"`
=== RUN   TestAccCloudProjectDatabasePostgresqlConnectionPool_importBasic
    provider_test.go:332: Read Cloud Project /cloud/project/9a37012689924595bf55df59a2b1f5b6 -> status: 'ok', desc: '(POC) AI'
--- PASS: TestAccCloudProjectDatabasePostgresqlConnectionPool_importBasic (363.45s)
PASS

Test Configuration:

• Terraform version: terraform version: Terraform v1.2.9
• Existing HCL configuration you used:

Creating a database in a Postgresql 15 database cluster, then a user for it & a connection pool for that user so he can access this database

resource "ovh_cloud_project_database" "db" {
	service_name = "XXXXXX"
	description  = "test-pg-cluster"
	engine       = "postgresql"
	version      = "15"
	plan         = "essential"
	nodes {
		region     = "GRA"
	}
	flavor = "db1-4"
}

resource "ovh_cloud_project_database_database" "database" {
  service_name  = ovh_cloud_project_database.db.service_name
  engine        = ovh_cloud_project_database.db.engine
  cluster_id    = ovh_cloud_project_database.db.id
  name          = "mydatabase"
}

resource "ovh_cloud_project_database_postgresql_user" "user" {
	service_name = ovh_cloud_project_database.db.service_name
	cluster_id   = ovh_cloud_project_database.db.id
	name		 = "johndoe"
	roles 		 = ["replication"]
}

resource "ovh_cloud_project_database_postgresql_connection_pool" "connection_pool" {
  service_name = ovh_cloud_project_database.db.service_name
  cluster_id   = ovh_cloud_project_database.db.id
  database_id = ovh_cloud_project_database_database.database.id
  name = "test_connection_pool"
  user_id = ovh_cloud_project_database_postgresql_user.user.id
  mode = "session"
  size = 13
}

data "ovh_cloud_project_database_postgresql_connection_pool" "connection_pool" {
  service_name = ovh_cloud_project_database_postgresql_connection_pool.connection_pool.service_name
  cluster_id   = ovh_cloud_project_database_postgresql_connection_pool.connection_pool.cluster_id
  name         = ovh_cloud_project_database_postgresql_connection_pool.connection_pool.name
}

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added acceptance tests that prove my fix is effective or that my feature works
• New and existing acceptance tests pass locally with my changes

[lpatte]

Thank you for your contribution.
LGTM in general.
Only some comment to simplify code and remove unused parameters

[julianguinard]

Thank you for your contribution. LGTM in general. Only some comment to simplify code and remove unused parameters

Thanks for your review Ludwig, suggestions applied there

[amstuta]

Apart from the style comments, OK to merge

[amstuta]

Suggested change

	endpoint := fmt.Sprintf("/cloud/project/%s/database/%s/%s/connectionPool",
	endpoint := fmt.Sprintf("/cloud/project/%s/database/postgresql/%s/connectionPool",

no need to insert this dynamically

[julianguinard]

@amstuta style suggestions applied here
Needs re-approval