Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the ovh_dedicated_server_boots documentation #473

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Update the ovh_dedicated_server_boots documentation #473

merged 1 commit into from
Nov 7, 2023

Conversation

antham
Copy link
Contributor

@antham antham commented Sep 20, 2023

Description

Update the ovh_dedicated_server_boots documentation to add a missing parameter kernel which is defined but not exposed in the documentation.

Type of change

Please delete options that are not relevant.

  • Documentation update

How Has This Been Tested?

Not tested this a documentation change

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran succesfully go mod vendor if I added or modify go.mod file

@amstuta
Copy link
Contributor

amstuta commented Nov 7, 2023

@antham the parameter kernel has been removed a while ago from the API, as you can see in the spec of the route here: https://api.ovh.com/console-preview/?section=%2Fdedicated%2Fserver&branch=v1#get-/dedicated/server/-serviceName-/boot
As a result, I think we should remove the parameter instead of updating the documentation

@antham
Copy link
Contributor Author

antham commented Nov 7, 2023

Ok I thought it was the other way around. This is a bit a problem because without this parameter you cannot point out a specific script if you have several or I missed something.

@antham
Copy link
Contributor Author

antham commented Nov 7, 2023

I think I misread what you said, I was able to use this kernel parameter, it worked and you say this is completely removed?

@amstuta
Copy link
Contributor

amstuta commented Nov 7, 2023

My bad, I misread the datasource: all the scripts are fetched and then filtered using the kernel parameter. I'll merge your PR then.

@amstuta amstuta merged commit 7d40b84 into ovh:master Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants