-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add OIDC configuration to containerRegistry #459
Conversation
6b72ed0
to
45317fd
Compare
website/docs/d/cloud_project_containerregistry_oidc.html.markdown
Outdated
Show resolved
Hide resolved
* `oidc_name` - The name of the OIDC provider. | ||
* `oidc_endpoint` - The URL of an OIDC-compliant server. | ||
* `oidc_client_id` - The client ID with which Harbor is registered as client application with the OIDC provider. | ||
* `oidc_client_secret` - The secret for the Harbor client application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't I delete it as it's not part of the Data schema anymore ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if fields are not in the datasource, yes delete it/them :)
45317fd
to
e50c295
Compare
* `oidc_name` - The name of the OIDC provider. | ||
* `oidc_endpoint` - The URL of an OIDC-compliant server. | ||
* `oidc_client_id` - The client ID with which Harbor is registered as client application with the OIDC provider. | ||
* `oidc_client_secret` - The secret for the Harbor client application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if fields are not in the datasource, yes delete it/them :)
e50c295
to
057813b
Compare
Signed-off-by: Thomas Coudert <[email protected]>
057813b
to
b412507
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks :)
Description
Add Managed Private Registry OIDC configuration (relative to ovh/public-cloud-roadmap#83)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
make testacc TESTARGS="-run TestAccCloudProjectContainerRegistryOIDCDataSource_basic"
make testacc TESTARGS="-run TestAccCloudProjectContainerRegistryOIDC_full"
Test Configuration:
terraform version
: Terraform v1.2.6Checklist:
go mod vendor
if I added or modifygo.mod
file