-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cloudProject): creation and import for cloudProject in the US #455
fix(cloudProject): creation and import for cloudProject in the US #455
Conversation
2907590
to
a0176cd
Compare
a0176cd
to
979064b
Compare
Hello, Is there anything missing on this PR ? Or can we merge it ? |
We are waiting for an US account in order to test everything as the user will do. |
979064b
to
d6d2b9b
Compare
Creation of public cloud project patched. The deletion (and update) of a public cloud project in the US is not working yet because @yomovh & myself will see how we deal with it. |
d6d2b9b
to
9d9f25e
Compare
We don't want to put too much US specific logic in the provider and will work into getting resources ordered through So for now, as agreed with @yomovh, I added a notice about the known issue that a public cloud project cannot be deleted in the US through Terraform. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR
After all the things we saw, edited and fixed, now, the PR is good for me 💪 |
Description
This PR fixes public cloud project creation for OVH US. It also improves cloud project documentation so that creation in the US is easier for end user.
Because of some differences in Agora, the result is different between OVH EU/CA on one side & OVH US on the other. There's been some internal discussions about changing that (I can provide more details in PM) and they haven't landed on a result and are not expected to in any near future.
This PR works around the issue by making extra call to find out serviceName if the initial serviceName determination attempt failed.
Type of change
How Has This Been Tested?
I manually tested it by successfully creating & importing a cloud project on OVH-US.
Test Configuration:
terraform version
: Terraform v1.4.2export OVH_ENDPOINT=ovh-us
And also `terraform import ovh_cloud_project.cloud_project <project_id>
Checklist:
go mod vendor
if I added or modifygo.mod
file