Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kafka schema registry tests add import test #454

Conversation

BellionBastien
Copy link
Member

@BellionBastien BellionBastien commented Aug 23, 2023

Description

Fixes Kafka schema registry data source test
Add Kafka schema registry import test

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (improve existing resource(s) or datasource(s))

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A: make testacc TESTARGS="-run TestAccCloudProjectDatabaseKafkaSchemaregistryacl_importBasic""
  • Test B: make testacc TESTARGS="-run make testacc TESTARGS="-run TestAccCloudProjectDatabaseKafkaSchemaregistryaclsDataSource_basic""
  • Test c: make testacc TESTARGS="-run TestAccCloudProjectDatabaseKafkaSchemaregistryacl_basic""

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran succesfully go mod vendor if I added or modify go.mod file

@scraly scraly added the 0.33.0 label Aug 23, 2023
@BellionBastien BellionBastien force-pushed the dev/bbellion/fix-kafka-schema-registry-acl-tests branch from 5a985da to 734daff Compare August 23, 2023 15:39
@scraly scraly merged commit 312c1a6 into ovh:master Aug 24, 2023
@scraly
Copy link
Collaborator

scraly commented Aug 24, 2023

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants