Request cluster_id and service_name for a dbaas_logs_cluster resource…

[vaxvms]

…/data

You can have more than one cluster_id per service_name

Description

Instead on blindly selecting the first cluster_id of a service_name in dbaas_logs_cluster resource and data, request the user to give it.

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Improvement (improve existing resource(s) or datasource(s))
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

• Test A: make testacc TESTARGS="-run TestAccDataSourceXxxxYyyyZzzzz_basic"
• Test B: make testacc TESTARGS="-run TestAccDataSourceXxxxYyyyZzzzz_basic"

Test Configuration:

• Terraform version: terraform version: Terraform vx.y.z
• Existing HCL configuration you used:

resource "" "" {
 xx = "yy"
 zz = "aa"
}

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings or issues
• I have added acceptance tests that prove my fix is effective or that my feature works
• New and existing acceptance tests pass locally with my changes
• I ran succesfully go mod vendor if I added or modify go.mod file

[scraly]

The /dbaas/logs/{serviceName}/cluster API endpoint allow users to display the list of cluster IDs linked to the LDP:

So in Terraform, we should have the same behavior : display the list of cluster IDs with a given serviceName/LDP ID.

So, I think a prerequisite for this PR should be to add a dbaas_logs_clusters datasource that list all the existing cluster IDs.
And then, as the suer can have a clusterID with Terraform, then he or she can have a cluster details.

WDYT?

[vaxvms]

You're right, it's done

[vaxvms]

• id of dbaas_logs_cluster is now a concatenation of service name and cluster id. It will break existing usage.
• if cluster id isn't provided, the cluster_id of the default cluster is used

[rbeuque74]

To stay aligned with the resource:

Suggested change

	d.SetId(clusterId)
	d.SetId(serviceName+"_"+clusterId)

[rbeuque74]

Just this one comment, and we will be good :)

[rbeuque74]

Thanks for your contribution