Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resource dedicated_server_networking #351

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

wilfriedroset
Copy link
Contributor

Tested with my account

❯ make testacc TESTARGS="-run TestAccresourceDedicatedServerNetworking"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccresourceDedicatedServerNetworking -timeout 240m
?       github.com/ovh/terraform-provider-ovh   [no test files]
=== RUN   TestAccresourceDedicatedServerNetworking
--- PASS: TestAccresourceDedicatedServerNetworking (3468.55s)
PASS
ok      github.com/ovh/terraform-provider-ovh/ovh       3468.986s
?       github.com/ovh/terraform-provider-ovh/ovh/helpers       [no test files]
testing: warning: no tests to run
PASS
ok      github.com/ovh/terraform-provider-ovh/ovh/helpers/hashcode      (cached) [no tests to run]


## Example Usage

The following example aims to bond all interfaces in vRack.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following example aims to bond all interfaces in vRack.
The following example aims to bind all interfaces in a vRack

service_name = local.dedicated_server
# Bond the two first interfaces in the first vrack
interfaces {
macs = slice(sort(flatten(data.ovh_dedicated_server.server.vnis.*.nics)), 0, 2),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
macs = slice(sort(flatten(data.ovh_dedicated_server.server.vnis.*.nics)), 0, 2),
macs = slice(sort(flatten(data.ovh_dedicated_server.server.vnis.*.nics)), 0, 2)

}
# Bond the two last interfaces in the last vrack
interfaces {
macs = slice(sort(flatten(data.ovh_dedicated_server.server.vnis.*.nics)), 2, 4),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
macs = slice(sort(flatten(data.ovh_dedicated_server.server.vnis.*.nics)), 2, 4),
macs = slice(sort(flatten(data.ovh_dedicated_server.server.vnis.*.nics)), 2, 4)

}
# Bond the two last interfaces in the last vrack
interfaces {
macs = slice(sort(flatten(data.ovh_dedicated_server.server.vnis.*.nics)), 2, 4),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
macs = slice(sort(flatten(data.ovh_dedicated_server.server.vnis.*.nics)), 2, 4),
macs = slice(sort(flatten(data.ovh_dedicated_server.server.vnis.*.nics)), 2, 4)


The following arguments are required:

* `service_name` - (String) The service_name of your dedicated server.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `service_name` - (String) The service_name of your dedicated server.
* `service_name` - (String) The service_name of your dedicated server. The full list of available dedicated servers can be found using the `ovh_dedicated_servers` datasource.


Required:

* `macs` (List of String) List of mac addresses to bond together.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* `macs` (List of String) List of mac addresses to bond together.
* `macs` (List of String) List of mac addresses to bind together.

@wilfriedroset wilfriedroset force-pushed the dedicated-server-networking branch 2 times, most recently from b71d02a to 644a2b4 Compare January 3, 2023 14:16
@wilfriedroset wilfriedroset force-pushed the dedicated-server-networking branch 2 times, most recently from 610b941 to 3c8d098 Compare January 3, 2023 15:06
@wilfriedroset wilfriedroset force-pushed the dedicated-server-networking branch from 3c8d098 to 543a89f Compare January 3, 2023 15:13
Copy link
Collaborator

@scraly scraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's now OK for me :-)

@scraly scraly added the 0.26.0 label Jan 4, 2023
@scraly scraly merged commit 595a6d1 into ovh:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants