Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ovh_cloud_project_region_storage_presign): add resource #326

Merged
merged 1 commit into from
Nov 18, 2022

Conversation

Arnoways
Copy link
Contributor

Use this resource to presign url to interact with s3 fast storage.

This can be used for multiple uses-cases like uploading a post-install script to s3 then passing the URL to a dedicated_server install task. The URL is signed for a fixed period, hence the expire parameter.

Signed-off-by: Arnaud SINAYS [email protected]

Copy link
Collaborator

@yanndegat yanndegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests are missing

resource should be named after the api endpoint

/cloud/project//region//storage//presign

thus

ovh_cloud_project_region_storage_presign

@Arnoways Arnoways force-pushed the dev/arnoways/cloud_s3_storage_presign branch 2 times, most recently from e563aff to 9066fd1 Compare November 9, 2022 10:54
@Arnoways Arnoways changed the title feat(ovh_cloud_project_storage_s3_presign): add resource feat(ovh_cloud_project_region_storage_presign): add resource Nov 9, 2022
@Arnoways Arnoways requested a review from yanndegat November 9, 2022 15:22
Copy link
Collaborator

@scraly scraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you take a look to the environment variable renaming proposition please? :)

@Arnoways Arnoways force-pushed the dev/arnoways/cloud_s3_storage_presign branch from 36d18f9 to 9961049 Compare November 16, 2022 10:38
@Arnoways Arnoways requested a review from scraly November 17, 2022 13:57
@scraly
Copy link
Collaborator

scraly commented Nov 18, 2022

Test with an high performance storage, in GRA region, KO for the moment,
waiting for information to fix the problem :)

Copy link
Collaborator

@scraly scraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working now, just several request changes, thanks

Use this resource to presign url to interact with s3 fast storage.

This can be used for multiple uses-cases like uploading a post-install
script to s3 then passing the URL to a dedicated_server install task.
The URL is signed for a fixed period, hence the `expire` parameter.

Signed-off-by: Arnaud SINAYS <[email protected]>
@Arnoways Arnoways force-pushed the dev/arnoways/cloud_s3_storage_presign branch from 9961049 to ddb1a2c Compare November 18, 2022 13:26
@Arnoways Arnoways requested a review from scraly November 18, 2022 13:28
@scraly scraly merged commit 20eef00 into ovh:master Nov 18, 2022
@scraly scraly added the 0.23.0 label Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants