new resources/datasources: me_installation_template* #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yanndegat
commented
Nov 15, 2019
yanndegat
commented
- datasource/ovh_me_installation_templates
- datasource/ovh_me_installation_template
- resource/ovh_me_installation_template
- resource/ovh_me_installation_template_partition_scheme
- resource/ovh_me_installation_template_partition_scheme_hardware_raid
- resource/ovh_me_installation_template_partition_scheme_partition
ghost
added
the
|
/hold missing:
|
yanndegat
force-pushed
the
dev/ovh_me_installation_template
branch
from
665f75c to
665169c
Compare
pgaxatte
suggested changes
Nov 15, 2019
| templateName := d.Get("template_name").(string) | ||
|
|
||
| opts := (&PartitionSchemeCreateOrUpdateOpts{}).FromResource(d) | ||
| endpoint := fmt.Sprintf("/me/installationTemplate/%s/partitionScheme", templateName) |
|
|
||
| opts := (&InstallationTemplateCreateOpts{}).FromResource(d) | ||
|
|
||
| endpoint := fmt.Sprintf("/me/installationTemplate") |
There was a problem hiding this comment.
fmt.Sprintf is not needed here
|
Also you're missing the documentation ;) |
- datasource/ovh_me_installation_templates - datasource/ovh_me_installation_template - resource/ovh_me_installation_template - resource/ovh_me_installation_template_partition_scheme - resource/ovh_me_installation_template_partition_scheme_hardware_raid - resource/ovh_me_installation_template_partition_scheme_partition
yanndegat
force-pushed
the
dev/ovh_me_installation_template
branch
from
665169c to
27fc189
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.